Skip to content

removes the use of integer type from registries format #4015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 27, 2024
Merged

removes the use of integer type from registries format #4015

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d3a7a0e
fix: missing integer type for integer formats
baywet Aug 13, 2024
2640a03
fix: removes the use of integer base type
baywet Aug 21, 2024
eddb9b2
fix: changes terminology for type to align with spec updates
baywet Aug 21, 2024
d3b96de
Harmonize terminology
ralfhandl Aug 22, 2024
7446e7b
Apply suggestions from code review
baywet Aug 22, 2024
60d7ecd
fix: reverts to JSON data type to align with spec
baywet Aug 22, 2024
baa81d0
Apply suggestions from code review
ralfhandl Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion _includes/format-entry.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## {{ page.slug }} - {{ page.description }}

Base type: `{{ page.base_type | join:', ' }}`.
JSON Data Type: `{{ page.base_type | join:', ' }}`.

{{ include.summary }}

Expand Down
2 changes: 1 addition & 1 deletion registries/_format/double-int.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
owner: mikekistler
issue:
description: an integer that can be stored in an IEEE 754 double-precision number without loss of precision
base_type: integer
base_type: number
layout: default
---

Expand Down
2 changes: 1 addition & 1 deletion registries/_format/sf-integer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ issue:
description: structured fields integer as defined in [RFC8941]
source: https://www.rfc-editor.org/rfc/rfc8941#name-integers
source_label: RFC 8941
base_type: [integer, number]
base_type: number
layout: default
---

Expand Down
3 changes: 1 addition & 2 deletions registry/format.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,13 @@ If tools choose to implement any format present in this registry, they SHOULD im

The registry SHOULD NOT contain two entries that have the same meaning, unless all but one have been deprecated.


## Contributing

Please raise a [Pull-Request](https://github.com/OAI/OpenAPI-Specification/pulls) or [Issue](https://github.com/OAI/OpenAPI-Specification/issues) to contribute or discuss a registry value.

## Values

|Value|Description|Type|Source|Deprecated|
|Value|Description|JSON Data Type|Source|Deprecated|
|---|---|----|---|---|----|
{% for value in site.format %}| <a href="./{{ value.slug }}.html">{{ value.slug }}</a> | {{ value.description }} | {{ value.base_type | join: ', ' }} | {% if value.source %}<a href="{{ value.source }}">{% if value.source_label %}{{value.source_label}}{% else %}Open{% endif %}</a>{% endif %} | {% if value.deprecated_note %}Yes{% else %}No{% endif %} |
{% endfor %}
Expand Down