Skip to content

3.1.1: tables cleanup #4056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 29, 2024
Merged

3.1.1: tables cleanup #4056

merged 1 commit into from
Aug 29, 2024

Conversation

ralfhandl
Copy link
Contributor

@ralfhandl ralfhandl added script Pull requests that update Bash or JavaScript code editorial Wording and stylistic issues approved pr port PRs that just port an approved PR to another version labels Aug 29, 2024
@ralfhandl ralfhandl requested review from a team, handrews, lornajane and mikekistler August 29, 2024 15:48
@ralfhandl ralfhandl added this to the v3.1.1 milestone Aug 29, 2024
@ralfhandl ralfhandl changed the title 3.1.1 port of #4040 3.1.1: tables cleanup Aug 29, 2024
mikekistler
mikekistler approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

Tip to other reviewers: You can "hide whitespace" when reviewing on GitHub and that makes the spec file diff much smaller -- only table header changes remain.

@ralfhandl ralfhandl mentioned this pull request Aug 29, 2024
Closed
@lornajane lornajane merged commit 45b8742 into OAI:v3.1.1-dev Aug 29, 2024
1 check passed
@ralfhandl ralfhandl deleted the 3.1.1-table-cleanup branch August 29, 2024 16:34
@ralfhandl ralfhandl mentioned this pull request Sep 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lornajane lornajane lornajane approved these changes

@miqui miqui miqui approved these changes

@mikekistler mikekistler mikekistler approved these changes

@handrews handrews Awaiting requested review from handrews

Assignees
No one assigned
Labels
approved pr port PRs that just port an approved PR to another version editorial Wording and stylistic issues script Pull requests that update Bash or JavaScript code
Projects
None yet
Milestone
v3.1.1
Development

Successfully merging this pull request may close these issues.
4 participants
@ralfhandl @lornajane @miqui @mikekistler