Skip to content

Conversation

handrews
Copy link
Member

This includes the few commits that were:

  • part of v3.2.0-dev
  • not part of v3.1.1-dev
  • not about removing the special Path Item Object $ref, or undo-ing that removal (let's just skip the whole thing...)

These were handled with git format-patch and git am, like we have been doing to sync different release lines. In some cases, I noticed that the anchors for the new fields were incorrect and fixed them as if they were git am merge conflicts (so there are not separate commits).

So this should be as close to what's on v3.2.0-dev in the versions/3.2.0.md file as we need it to be. But not identical.

@handrews handrews added the approved pr port PRs that just port an approved PR to another version label Nov 11, 2024
@handrews handrews added this to the v3.2.0 milestone Nov 11, 2024
@handrews handrews requested review from a team as code owners November 11, 2024 00:02
Copy link
Contributor

@ralfhandl ralfhandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, one nit that I could address in a separate PR if I absolutely have to 😎

@ralfhandl ralfhandl requested a review from a team November 12, 2024 12:21
mikekistler
mikekistler previously approved these changes Nov 12, 2024
Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@handrews
Copy link
Member Author

@ralfhandl I merged your nit even though this was a port :-) Could you and @mikekistler please re-approve?

ralfhandl
ralfhandl previously approved these changes Nov 12, 2024
@ralfhandl
Copy link
Contributor

@handrews Gladly, thanks!

@ralfhandl ralfhandl requested review from a team and mikekistler November 12, 2024 16:52
@lornajane lornajane marked this pull request as draft November 14, 2024 17:15
@lornajane
Copy link
Contributor

Changed to draft status to allow more discussion of the best way to add these and possibly other changes. There's more discussion on #4106

@karenetheridge
Copy link
Member

Looks like there would be schema changes to accompany these?

@handrews
Copy link
Member Author

In the TDC Call we decided to defer CIBA to 3.3 based on #4106 (if that somehow comes together quickly enough, it can get on the 3.2 train, but we won't hold up 3.2 since we're going to do 3.3 immediately after per #4210). I'm going to remove the CIBA commit(s) and take this out of draft.

@karenetheridge since this is just porting pre-existing work, please feel free to make a follow-up PR for the relevant schema changes on the v3.2-dev branch. I don't want to introduce new work in this PR.

@handrews handrews marked this pull request as ready for review November 22, 2024 18:19
@handrews handrews mentioned this pull request Nov 22, 2024
5 tasks
@lornajane lornajane merged commit d2c39a8 into OAI:v3.2-dev Nov 28, 2024
2 checks passed
@handrews handrews deleted the v3.2-migrate branch June 19, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved pr port PRs that just port an approved PR to another version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants