adds server url template abnf by baywet · Pull Request #4264 · OAI/OpenAPI-Specification

baywet · 2024-12-18T12:59:05Z

partial #3256
related #4244

Signed-off-by: Vincent Biret <vibiret@microsoft.com>

baywet · 2024-12-18T13:00:08Z

src/oas.md

handrews · 2024-12-19T17:46:59Z

After discussion in TDC we agreed that pchar is not the right rule and we should use the general literals per RFC6570.

Signed-off-by: Vincent Biret <vibiret@microsoft.com>

src/oas.md

Co-authored-by: Vladimír Gorej <vladimir.gorej@gmail.com>

src/oas.md

Signed-off-by: Vincent Biret <vibiret@microsoft.com>

baywet · 2024-12-19T19:45:22Z

@handrews @char0n @ralfhandl I think we're ready for final review here :)

src/oas.md

ralfhandl

Align with https://www.rfc-editor.org/errata/eid6937

src/oas.md

Co-authored-by: Ralf Handl <ralf.handl@sap.com>

…r diverging future updates Signed-off-by: Vincent Biret <vibiret@microsoft.com>

char0n

LGTM, I've tested it as well, compiles and parses correctly.

src/oas.md

Co-authored-by: Vladimír Gorej <vladimir.gorej@gmail.com>

handrews · 2024-12-23T20:22:48Z

Random question- why does this PR start with "docs:"? It's a spec PR, not a docs PR. I keep overlooking it because of this.

baywet · 2024-12-23T20:45:03Z

Random question- why does this PR start with "docs:"? It's a spec PR, not a docs PR. I keep overlooking it because of this.

Muscle memory: on most repos I work on, we follow semantic commits. And usually when I touch Md files there, it's documentation.

GitHub CLI: -f uses the first commit when creating a PR.

handrews · 2024-12-23T23:46:54Z

@baywet thank you for satisfying my curiosity! Yeah, this project is a little unusual in that the spec markdown is really the "source". "Docs" to me are things like CONTRIBUTING.md and the README.

src/oas.md

Co-authored-by: Vladimír Gorej <vladimir.gorej@gmail.com>

Signed-off-by: Vincent Biret <vibiret@microsoft.com>

char0n · 2024-12-28T08:45:22Z

I'm doing some final testing on extended test suite - will check back here when everything glows green.

Refs OAI/OpenAPI-Specification#4264 Refs #73

char0n

LGTM, all tests on extended test-suite turned green

miqui

looks good - discussed during TDC.

docs: adds server url template anbf

ee4b871

Signed-off-by: Vincent Biret <vibiret@microsoft.com>

baywet requested review from a team as code owners December 18, 2024 12:59

baywet mentioned this pull request Dec 18, 2024

Formally define (ABNF) 3.x URL templating behavior #3256

Closed

char0n reviewed Dec 18, 2024

View reviewed changes

src/oas.md Show resolved Hide resolved

ralfhandl changed the title ~~docs: adds server url template anbf~~ docs: adds server url template abnf Dec 18, 2024

baywet mentioned this pull request Dec 19, 2024

Open Community (TDC) Meeting, Thursday 19 December 2024 #4251

Closed

karenetheridge mentioned this pull request Dec 19, 2024

request URI matching: include server object's url field karenetheridge/OpenAPI-Modern#11

Closed

baywet mentioned this pull request Dec 19, 2024

Add/update examples for new templating abnf OAI/learn.openapis.org#120

Open

fix: expands the allowed set for server templates literal

a89f36d

Signed-off-by: Vincent Biret <vibiret@microsoft.com>

baywet requested review from char0n and ralfhandl December 19, 2024 18:28

char0n reviewed Dec 19, 2024

View reviewed changes

src/oas.md Outdated Show resolved Hide resolved

fix: adds literals to the list of imported definitions

72eec29

Co-authored-by: Vladimír Gorej <vladimir.gorej@gmail.com>

baywet requested a review from char0n December 19, 2024 19:41

baywet commented Dec 19, 2024

View reviewed changes

src/oas.md Outdated Show resolved Hide resolved

baywet added 2 commits December 19, 2024 14:42

nit: groups literals with the imported definitions

cf00256

nit: aligns literal definition

069f2be

Signed-off-by: Vincent Biret <vibiret@microsoft.com>

char0n reviewed Dec 19, 2024

View reviewed changes

src/oas.md Outdated Show resolved Hide resolved

char0n reviewed Dec 19, 2024

View reviewed changes

src/oas.md Outdated Show resolved Hide resolved

ralfhandl requested changes Dec 20, 2024

View reviewed changes

src/oas.md Outdated Show resolved Hide resolved

baywet and others added 2 commits December 20, 2024 08:41

fix: updates literals with content from errata

e3f9dca

Co-authored-by: Ralf Handl <ralf.handl@sap.com>

nit: changes the server variable name to avoid confusion and allow fo…

d1ce259

…r diverging future updates Signed-off-by: Vincent Biret <vibiret@microsoft.com>

baywet requested review from char0n and ralfhandl December 20, 2024 13:45

char0n approved these changes Dec 20, 2024

View reviewed changes

char0n reviewed Dec 20, 2024

View reviewed changes

src/oas.md Outdated Show resolved Hide resolved

fix: adds mention that errata has been applied

45f197a

Co-authored-by: Vladimír Gorej <vladimir.gorej@gmail.com>

baywet requested a review from char0n December 23, 2024 12:32

baywet changed the title ~~docs: adds server url template abnf~~ adds server url template abnf Dec 23, 2024

ralfhandl previously approved these changes Dec 24, 2024

View reviewed changes

char0n reviewed Dec 25, 2024

View reviewed changes

src/oas.md Outdated Show resolved Hide resolved

char0n mentioned this pull request Dec 25, 2024

Fix Path Templating ABNF grammar #4279

Merged

fix: missing z character

bfd5088

Co-authored-by: Vladimír Gorej <vladimir.gorej@gmail.com>

baywet dismissed ralfhandl’s stale review via bfd5088 December 27, 2024 13:29

baywet requested review from char0n and ralfhandl December 27, 2024 13:29

baywet added 2 commits December 27, 2024 08:31

Merge branch 'v3.2-dev' into feat/server-template-abnf-to-3-2-dev

60a747f

fix: missing z in url templating

6e4f8d6

Signed-off-by: Vincent Biret <vibiret@microsoft.com>

char0n added a commit to swaggerexpert/openapi-server-url-templating that referenced this pull request Dec 28, 2024

feat: align grammar with OpenAPI specification

c5e2b8f

Refs OAI/OpenAPI-Specification#4264 Refs #73

char0n mentioned this pull request Dec 28, 2024

feat: align grammar with OpenAPI specification swaggerexpert/openapi-server-url-templating#77

Merged

char0n added a commit to swaggerexpert/openapi-server-url-templating that referenced this pull request Dec 28, 2024

feat: align grammar with OpenAPI specification (#77)

cfd099e

Refs OAI/OpenAPI-Specification#4264 Refs #73

char0n approved these changes Dec 28, 2024

View reviewed changes

baywet mentioned this pull request Dec 30, 2024

Open Community (TDC) Meeting, Thursday 02 January 2025 #4281

Closed

miqui approved these changes Jan 2, 2025

View reviewed changes

miqui merged commit 0d0c9da into OAI:v3.2-dev Jan 2, 2025
2 checks passed

baywet mentioned this pull request Jan 7, 2025

adds links to annex C in path and server templating sections #4292

Merged

Conversation

baywet commented Dec 18, 2024

Uh oh!

baywet commented Dec 18, 2024

Uh oh!

Uh oh!

handrews commented Dec 19, 2024

Uh oh!

Uh oh!

Uh oh!

baywet commented Dec 19, 2024

Uh oh!

Uh oh!

Uh oh!

ralfhandl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

char0n left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

handrews commented Dec 23, 2024

Uh oh!

baywet commented Dec 23, 2024

Uh oh!

handrews commented Dec 23, 2024

Uh oh!

Uh oh!

char0n commented Dec 28, 2024

Uh oh!

char0n left a comment

Choose a reason for hiding this comment

Uh oh!

miqui left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants