Skip to content

dev: use common spec build script for building from src/oas.md #4369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2025
Merged

dev: use common spec build script for building from src/oas.md #4369

merged 1 commit into from
Feb 20, 2025

Conversation

ralfhandl
Copy link
Contributor

  • npm build script build-src calls same bash script as npm script build
  • remove now unnecessary bash script build-src.sh

Tick one of the following options:

  • schema changes are included in this pull request
  • schema changes are needed for this pull request but not done yet
  • no schema changes are needed for this pull request

@ralfhandl ralfhandl requested review from a team as code owners February 18, 2025 08:34
@ralfhandl ralfhandl added Housekeeping script Pull requests that update Bash or JavaScript code labels Feb 18, 2025
@ralfhandl ralfhandl mentioned this pull request Feb 18, 2025
Closed
miqui
miqui approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@miqui miqui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@lornajane lornajane merged commit 35b2333 into OAI:dev Feb 20, 2025
2 checks passed
@ralfhandl ralfhandl deleted the dev-one-spec-build-script branch February 20, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lornajane lornajane lornajane approved these changes

@miqui miqui miqui approved these changes

+1 more reviewer

@duncanbeevers duncanbeevers duncanbeevers approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Housekeeping script Pull requests that update Bash or JavaScript code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ralfhandl @duncanbeevers @lornajane @miqui