Skip to content

Conversation

baywet
Copy link
Contributor

@baywet baywet commented Mar 28, 2025

fixes #1747

@baywet baywet requested review from a team as code owners March 28, 2025 12:55
@baywet baywet mentioned this pull request Mar 28, 2025
33 tasks
Copy link
Contributor

@ralfhandl ralfhandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a failing test case trying to use "GET" as an additional operation?

@baywet baywet requested a review from ralfhandl March 28, 2025 14:23
@baywet
Copy link
Contributor Author

baywet commented Mar 28, 2025

Could you please add a failing test case trying to use "GET" as an additional operation?

done. I added POST instead to make it clear that it's not just a collision with what's defined in the document, but rather a matter of "where things should go".

@handrews
Copy link
Member

@baywet @kevinswiber I did not see a reply in the issue to my idea that we include query among the special-cased fields rather than relegating it to additionalOperations, since it is on the verge of becoming an IANA-registered general-purpose (non-WebDAV) HTTP method. I would prefer that approach.

@baywet
Copy link
Contributor Author

baywet commented Mar 31, 2025

@baywet @kevinswiber I did not see a reply in the issue to my idea that we include query among the special-cased fields rather than relegating it to additionalOperations, since it is on the verge of becoming an IANA-registered general-purpose (non-WebDAV) HTTP method. I would prefer that approach.

I don't have a strong preference either way. If it's about to be a "well known" method/verb, I think it makes sense to hoist it. Added it (push soon).

@baywet baywet requested review from handrews and ralfhandl March 31, 2025 18:09
Signed-off-by: Vincent Biret <[email protected]>
handrews
handrews previously approved these changes Mar 31, 2025
Copy link
Member

@handrews handrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and fixing my copy-paste error!

handrews
handrews previously approved these changes Mar 31, 2025
@baywet
Copy link
Contributor Author

baywet commented Apr 1, 2025

@ralfhandl for a final review/approval/merge with the latest minor edits

Copy link
Contributor

@ralfhandl ralfhandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, just one typo and one omission

Co-authored-by: Ralf Handl <[email protected]>
@baywet baywet requested review from handrews and ralfhandl April 1, 2025 12:57
@ralfhandl ralfhandl requested a review from a team April 1, 2025 13:12
@ralfhandl ralfhandl merged commit 7b29ee4 into OAI:v3.2-dev Apr 1, 2025
2 checks passed
@baywet baywet deleted the feat/additional-operations branch April 1, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement http Supporting HTTP features and interactions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants