main: avoid unconventional use of yargs #4638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralfhandl
added
Housekeeping
javascript
There was a problem hiding this comment.
Pull Request Overview
This PR updates the conventional use of yargs in md2html.js to ensure compatibility with version 18 and increases the test timeout in vitest.config.mjs to handle occasional slow tests.
- Updated yargs usage in md2html.js by slicing process.argv and using .parse() as per documentation.
- Increased vitest testTimeout to 10 seconds to mitigate test timing issues.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| vitest.config.mjs | Added testTimeout for improved test reliability |
| scripts/md2html/md2html.js | Updated yargs usage for compatibility with version 18 |
handrews
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
yargspackage was used in a (now?) unconventional way in scriptmd2html.jswhich no longer works with version 18 ofyargs. Switched to more conventional use following the yargs documentation.Increased vitest timeout for tests to avoid occasional problems.