Skip to content

Conversation

ralfhandl
Copy link
Contributor

@ralfhandl ralfhandl commented Jun 11, 2025

The schema-test-coverage.sh script will now exit with code 1 if schema coverage falls below 100%, except on the dev branch, where we have insufficient test cases.

This will prevent schema additions without accompanying test cases, which we recently had on v3.2-dev.

Tested with dummy PRs:

  • schema changes are included in this pull request
  • schema changes are needed for this pull request but not done yet
  • no schema changes are needed for this pull request

@ralfhandl ralfhandl requested review from a team as code owners June 11, 2025 18:19
@ralfhandl ralfhandl added Housekeeping script Pull requests that update Bash or JavaScript code labels Jun 11, 2025
@handrews handrews merged commit 9b01d59 into OAI:main Jun 11, 2025
2 checks passed
@ralfhandl ralfhandl deleted the main-fail-if-schema-test-coverage-falls-below-100-percent branch June 11, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Housekeeping script Pull requests that update Bash or JavaScript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants