Use the full schema (schema-base.yaml) for testing and coverage #4700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we are testing with a placeholder, we need to match the placeholder. This will unfortunately need to be different on each new release line branch, so let's separate this test case into its own file.
|
Arg- apparently this needs to start on main even though we don't have tests there? I'll close this and re-submit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not actually using the correct schema for our testing, which meant that we were not covering the Schema Object at all. This fixes that, at least for the
npm run testswith coverage. The same could also be done intests/schema/schema.test.mjsbut I can't figure out what that script is for- is it redundant? Can we delete it or consolidate it with the coverage one?Note that we will need to modify the
jsonSchemaDialecttest per dev branch, which is why I split it out into its own file instead of leaving it inmega.yaml.We do not have full coverage anyway on
dev, but I will work on it forv3.1-devandv3.2-dev.