Skip to content

Conversation

handrews
Copy link
Member

@handrews handrews commented Aug 2, 2025

Fixes #4816.

The explode field defaults to false with style: deepObject, but the behavior of that combination is undefined in 3.0 and 3.1.

For 3.2, define it to behave the same as style: deepObject, explode: true, which maintains compatibility (by defining previously undefined behavior rather than changing the defined default value) and produces intuitive results.

Note that there is no need to update the Header Object because it does not allow style: deepObject.

  • no schema changes are needed for this pull request

The `explode` field defaults to `false` with `style: deepObject`,
but the behavior of that combination is undefined in 3.0 and 3.1.

For 3.2, define it to behave the same as
`style: deepObject, explode: true`, which maintains compatibility
(by defining previously undefined behavior rather than changing
the defined default value) and produces intuitive results.
@handrews handrews added this to the v3.2.0 milestone Aug 2, 2025
@handrews handrews requested review from a team as code owners August 2, 2025 18:58
@handrews handrews added the bug label Aug 2, 2025
@handrews handrews linked an issue Aug 2, 2025 that may be closed by this pull request
karenetheridge
karenetheridge previously approved these changes Aug 3, 2025
mikekistler
mikekistler previously approved these changes Aug 4, 2025
Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

Nice solution!

@handrews handrews dismissed stale reviews from mikekistler and karenetheridge via 533c6d3 August 7, 2025 18:58
@ralfhandl ralfhandl requested review from a team, karenetheridge and mikekistler August 8, 2025 08:32
Copy link
Member

@whitlockjc whitlockjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@handrews handrews merged commit adc6cb4 into OAI:v3.2-dev Aug 13, 2025
2 checks passed
@handrews handrews deleted the deepo branch August 27, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v3.1.1: style:deepObject should default to explode:true

5 participants