v3.2: Fix allowReserved

[handrews]

We want it to apply only when percent-encoding applies:

• in: path
• in: query
• in: cookie [no style- deafult is form]
• in: cookie, style: form

But not:

• in: header
• in: cookie, style: cookie

The schema changes needed for this are a bit complex to handle in: "cookie" with both no style, and with an expicit style: "form".

• schema changes are included in this pull request
• schema changes are needed for this pull request but not done yet
• no schema changes are needed for this pull request

[lornajane]

Good clarification, thanks

[lornajane]

Can we get a separate issue for the followup schema change so we don't lose it? I'm not sure I understand enough to create the issue.

[karenetheridge]

I can provide the schema changes to this PR.

[handrews]

@lornajane I added #4598 (comment) to the schema-tracking issue that I know @karenetheridge is already following.

[karenetheridge]

"This field only applies to.." -- is that intending to say that other combinations of properties are ILLEGAL? or simply that if they're there, they are ignored?

If the latter, then there are no schema changes to be made here.

[handrews]

@karenetheridge the "only applies" language has been there since 3.0.0, we're only broadening it's applicability a bit. So... whatever it meant before? I think we have interpreted that as "ignore", but I'm not 100% sure. Ignoring is it reasonable-ish, particularly with the new wording, as there are no reserved characters to allow for the field combinations to which it does not apply.

(TL;DR: don't know)

[karenetheridge]

I feel like we can't add exclusions to the schema here, at least not until 4.0 when breaking changes are allowed.