-
Notifications
You must be signed in to change notification settings - Fork 9.2k
v3.2: Add style: cookie, explain pct-encoding #4902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This adds a `style: cookie` to provide a non-percent-encoding option for managing cookie parameters. It also explains the conditions under which automatic percent-encoding with `style: form` might work, and also links to a draft update of the cookie RFC that explains that things that look like percent-encoding should _not_ be decoded for storage, which means that `style: cookie` is providing the most compliant behavior for that updated guidance.
d3b8ffd
to
b78f66a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments from the TDC call and some minor edits
Co-authored-by: Lorna Jane Mitchell <[email protected]> Co-authored-by: Vincent Biret <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll fix the remaining things soon- I think I have either accepted the suggestions or otherwise replied to all comments for now.
I have updated most of the things. Due to the state of my health and general exhaustion, I'd like to plead that we focus only on accuracy and not what examples or formatting might be nice to have. @lornajane – I changed "simulating" to "simulating/extending" which might make it a bit more clear why it's not just useing? idk. For the extra level on the examples, I'd happily approve a follow-on PR doing that to all of the examples in this section (although see next point below). @baywet – I'll follow up with you on slack, but the example request is a bit more complicated. I'll happy approve a follow-on PR from you, and answer any questions you might have while making it. @karenetheridge – I will gladly approve a PR removing the JSON-like formatting from |
Co-authored-by: Ralf Handl <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a new style seemed radical but I think it works!
Replaces PR #4822. Please pay close attention while reviewing, I wrote this through various bouts of illness and then split it from other smaller PRs, and I'm not entirely sure I got it all.
This adds a
style: cookie
to provide a non-percent-encoding option for managing cookie parameters.It also explains the conditions under which automatic percent-encoding with
style: form
might work, and also links to a draft update of the cookie RFC that explains that things that look like percent-encoding should not be decoded for storage, which means thatstyle: cookie
is providing the most compliant behavior for that updated guidance.