Skip to content

allow searching for PRs with needed schema changes #4960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2025
Merged

allow searching for PRs with needed schema changes #4960

merged 1 commit into from
Sep 16, 2025

Conversation

karenetheridge
Copy link
Member

  • no schema changes are needed for this pull request

@karenetheridge karenetheridge requested review from a team as code owners September 15, 2025 21:18
ralfhandl
ralfhandl requested changes Sep 15, 2025
View reviewed changes
Copy link
Contributor

@ralfhandl ralfhandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose to close this and create a PR for changing this in the main branch.

@karenetheridge karenetheridge force-pushed the ether/pull-request-schema-changes branch from e1adb6d to 1b3cdb1 Compare September 15, 2025 21:51
@karenetheridge karenetheridge changed the base branch from v3.1-dev to main September 15, 2025 21:51
@karenetheridge
Copy link
Member Author

Retargeted to main.

@ralfhandl ralfhandl requested review from a team and lornajane September 15, 2025 21:55
mikekistler
mikekistler approved these changes Sep 16, 2025
View reviewed changes
Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

But my experience with users following instructions in templates is not good. We may need some automation to enforce / clean this up when users don't follow instructions.

@ralfhandl ralfhandl merged commit faa46d2 into OAI:main Sep 16, 2025
2 checks passed
@karenetheridge karenetheridge deleted the ether/pull-request-schema-changes branch September 17, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralfhandl ralfhandl ralfhandl approved these changes

@mikekistler mikekistler mikekistler approved these changes

@lornajane lornajane Awaiting requested review from lornajane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karenetheridge @ralfhandl @mikekistler