Skip to content

Conversation

@ralfhandl
Copy link
Contributor

@ralfhandl ralfhandl commented Oct 21, 2024

Copies useful stuff over from OpenAPI repo and adjusts it for Overlay:

  • stub for schemas/v1.0/schema.yaml
  • tests for the schema with pass and fail test cases
  • all spec examples are pass test cases
  • workflow to run schema tests
  • validate script for ad-hoc schema validation

@ralfhandl ralfhandl requested review from jeremyfiel and kevinswiber and removed request for jeremyfiel October 21, 2024 16:02
@ralfhandl ralfhandl added this to the Release 1.0 milestone Oct 21, 2024
@ralfhandl ralfhandl requested a review from jeremyfiel October 23, 2024 07:34
Copy link
Contributor

@jeremyfiel jeremyfiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you merge the changes to your fork for the new tests I've committed? Other than the naming, lgtm!

@ralfhandl ralfhandl requested a review from jeremyfiel October 23, 2024 14:15
Copy link
Contributor

@jeremyfiel jeremyfiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@ralfhandl ralfhandl merged commit 004e0bc into OAI:main Nov 5, 2024
@ralfhandl ralfhandl deleted the schema-test branch November 5, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants