feat: add schema tests and official JSON Schema #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralfhandl
reviewed
Nov 5, 2024
ralfhandl
requested changes
Nov 7, 2024
jeremyfiel
force-pushed
the
schema-test
branch
from
979384c to
3111890
Compare
ralfhandl
reviewed
Nov 8, 2024
ralfhandl
reviewed
Nov 8, 2024
ralfhandl
reviewed
Nov 8, 2024
jeremyfiel
force-pushed
the
schema-test
branch
2 times, most recently
from
d1907bc to
84db575
Compare
ralfhandl
reviewed
Nov 11, 2024
ralfhandl
reviewed
Nov 11, 2024
ralfhandl
reviewed
Nov 11, 2024
|
@jeremyfiel Could you please add a That's the only part of the schema that is not yet tested. |
jeremyfiel
force-pushed
the
schema-test
branch
2 times, most recently
from
dc198e7 to
5517ebc
Compare
|
should be all covered now |
Sorry, should have been more precise: please add to a "pass" test case, the "fail" ones don't count into the schema coverage. |
jeremyfiel
force-pushed
the
schema-test
branch
from
5517ebc to
4b9a9d2
Compare
* fixup `target` json path * remove constraint for no update with remove * update schema tests for update and remove definition
jeremyfiel
force-pushed
the
schema-test
branch
from
4b9a9d2 to
6d0bc24
Compare
|
removed constraints for update/remove, updated tests |
|
@jeremyfiel How can I view the diff between this state and the last state I reviewed? |
|
There is a |
ralfhandl
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
includes pass and fail scenarios for Overlay schema tests.
Also includes the full schema per #72