[ADD] base, base_setup, web, web_editor, web_unsplash

[kos94ok-3D]

My first steps in the migration

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

[kos94ok-3D]

Hi, @MiquelRForgeFlow.
Can you help me? Is it a problem with Travis or I missing something?

[MiquelRForgeFlow]

I'm busy with other things, sorry but it's not my priority right now

[kos94ok-3D]

Hi, @StefanRijnhart .
Have you any time in order to help me? Is it a problem with Travis or I missing something?

[kos94ok-3D]

HI, @pedrobaeza.
Maybe you have any idea about an error in Travis.

[pedrobaeza]

Sorry, I'm not either on this.

[StefanRijnhart]

Very nice work, thank you! Travis failure might be related to an issue with the port of the OpenUpgrade framework to Odoo 13, c.q. running Openupgrade specific tests (of which there are none yet). Maybe you can reproduce the test error by running locally on an odoo 12 demodatabase with the OPENUPGRADE_TESTS=1 environment variable set?

[kos94ok-3D]

Very nice work, thank you! Travis failure might be related to an issue with the port of the OpenUpgrade framework to Odoo 13, c.q. running Openupgrade specific tests (of which there are none yet). Maybe you can reproduce the test error by running locally on an odoo 12 demodatabase with the OPENUPGRADE_TESTS=1 environment variable set?

Thank you.
I found two problems:

1. importlib.import_module can not correctly work with names which contains dots
2. tools.config['test_tags'] return None if not set so we get Traceback

What to do? Someone use migration tests? (I fixed it in #2207)

[StefanRijnhart]

Great work, thanks! I had been doing a bit of work on this module and I have a small number of minor additions that I will propose when this is merged.

[kos94ok-3D]

Great work, thanks! I had been doing a bit of work on this module and I have a small number of minor additions that I will propose when this is merged.

Thank you for review.
OK

[MiquelRForgeFlow]

@StefanRijnhart Is there such a hurry as to not wait for other opinions before merge?

One thing is that I said I can't "help" because I'm busy with other things and another thing is that I can't say something before it gets merged. It's not a trivial PR and more work needs to be done in base.

[pedrobaeza]

Yeah, I agree, because in documentation it mentions now that base module is Done, and possible issues that arises derived from it must be now attended. Better to remove that tag or put something like "tentative".

[StefanRijnhart]

Well, again I think projects like openupgrade benefit from optimistic merging, in which incomplete and suboptimal code can be merged if it constitutes an improvement and when tests are green.

[pedrobaeza]

As said, the problem is to qualify this "experimental" code (although of course it's a great achievement from a new contributor) as "Done" in the documentation.

[StefanRijnhart]

Follow up here: #2210