Skip to content

[13.0][MIG] website_blog#2374

Merged
OCA-git-bot merged 2 commits intoOCA:13.0from
ForgeFlow:13.0-mig-website_blog-script
Nov 19, 2020
Merged

[13.0][MIG] website_blog#2374
OCA-git-bot merged 2 commits intoOCA:13.0from
ForgeFlow:13.0-mig-website_blog-script

Conversation

@MiquelRForgeFlow
Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow commented Aug 4, 2020

Migration of website_blog.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@MiquelRForgeFlow MiquelRForgeFlow added this to the 13.0 milestone Aug 4, 2020
@pedrobaeza pedrobaeza mentioned this pull request Aug 4, 2020
Closed
yajo
yajo requested changes Oct 15, 2020
View reviewed changes
@yajo yajo mentioned this pull request Oct 15, 2020
Closed
yajo
yajo approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the fix for https://github.com/OCA/OpenUpgrade/pull/2374/files#r505465263 is in #2418, I approve this 😊

MiquelRForgeFlow and others added 2 commits November 3, 2020 15:52
@MiquelRForgeFlow
[MIG] website_blog
3902d58
@MiquelRForgeFlow
[FIX] website_blog: respect name and subtitle
fc5f138 
This shouldn't be included as a noupdate change. It should be respected as it was, instead.

@Tecnativa TT23136
@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 13.0-mig-website_blog-script branch from 6db81b4 to fc5f138 Compare November 3, 2020 14:53
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Nov 19, 2020

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@yajo
Copy link
Member

yajo commented Nov 19, 2020

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Nov 19, 2020

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-2374-by-Yajo-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 14dd0b6 into OCA:13.0 Nov 19, 2020
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Nov 19, 2020

Congratulations, your PR was merged at 14dd0b6. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 13.0-mig-website_blog-script branch November 19, 2020 17:40
@pedrobaeza
Copy link
Member

pedrobaeza commented Nov 19, 2020

@yajo why do you merge this if the dependencies are not merged?

@yajo
Copy link
Member

yajo commented Nov 19, 2020

Well it was approved, the code seems fine, and I didn't notice that label. (Actually I didn't know such a thing existed).

Anyways does this merge harm?

@pedrobaeza
Copy link
Member

pedrobaeza commented Nov 19, 2020

Yes, it can produce problems, as this is installing all the dependencies in Travis and thus some conflicts can arise, although Travis right now is green. Please don't do that next time or ask not being you a usual contributor here.

pedrobaeza
pedrobaeza reviewed Nov 19, 2020
View reviewed changes
@pedrobaeza
Copy link
Member

pedrobaeza commented Nov 19, 2020

@MiquelRForgeFlow @yajo I have detected that the migration scripts are not fully correct and it should be fixed. Please check.

@yajo
Copy link
Member

yajo commented Jan 20, 2021

All concerns solved in #2496

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedrobaeza pedrobaeza pedrobaeza left review comments

@yajo yajo yajo approved these changes

+1 more reviewer

@Abranes Abranes Abranes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Blocked by dependency merged 🎉 needs review ready to merge

Projects

None yet

Milestone

13.0

Development

Successfully merging this pull request may close these issues.

5 participants

@MiquelRForgeFlow @OCA-git-bot @yajo @pedrobaeza @Abranes