[13.0][FIX] base: Avoid possible issues with missing categories

[MiquelRForgeFlow]

Some databases may have missing a category for some reason. Just in case, assure the old category exists to avoid errors in cases of missing a category.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

[pedrobaeza]

I don't get the change. Isn't the same?

[pedrobaeza]

If not, reorder the code for clarity

[MiquelRForgeFlow]

I could have done this:

for old_xmlid, new_xmlid in xmlid_renames_ir_module_category:
        module, name = new_xmlid.split('.')
        sql = "SELECT res_id FROM ir_model_data WHERE module=%s AND name=%s"
        env.cr.execute(sql, (module, name))
        new_row = env.cr.fetchone()
        if new_row:
            module, name = old_xmlid.split('.')
            env.cr.execute(sql, (module, name))
            old_row = env.cr.fetchone()
            if old_row:
                openupgrade_merge_records.merge_records(
                    env, "ir.module.category", [old_row[0]], new_row[0],
                    method="sql", model_table="ir_module_category")
        else:
+            module, name = old_xmlid.split('.')
+            env.cr.execute(sql, (module, name))
+            old_row = env.cr.fetchone()
+            if old_row:
+               openupgrade.rename_xmlids(env.cr, [(old_xmlid, new_xmlid)])
-            openupgrade.rename_xmlids(env.cr, [(old_xmlid, new_xmlid)])

that shows clearly the change, but then I reordered it to avoid repeating:

           module, name = old_xmlid.split('.')
           env.cr.execute(sql, (module, name))
           old_row = env.cr.fetchone()
           if old_row:

[AaronHForgeFlow]

👍