[FIX] utm: fix utm.campaign model creation#2393
Closed
dennybiasiolli wants to merge 1 commit intoOCA:13.0from
Closed
[FIX] utm: fix utm.campaign model creation#2393dennybiasiolli wants to merge 1 commit intoOCA:13.0from
dennybiasiolli wants to merge 1 commit intoOCA:13.0from
Conversation
Before this fix, when trying to upgrade from Odoo 12.0 without
`utm.stage` table created, the creation follows a "top-down" logic,
creating `utm.campaign` with `stage_id` column referencing `utm.stage`
table in `stage_id` field default value:
```
stage_id = fields.Many2one('utm.stage', string='Stage',
ondelete='restrict', required=True,
default=lambda self: self.env['utm.stage'].search([],
limit=1),
group_expand='_group_expand_stage_ids')
```
This commit prevents errors like
`psycopg2.errors.UndefinedTable: relation "utm_stage" does not exist`
Member
|
Sorry, but we want to avoid such code diff in Odoo code, so better to continue in the other PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this fix, when trying to upgrade from Odoo 12.0 without
utm.stagetable created, the creation follows a "top-down" logic,creating
utm.campaignwithstage_idcolumn referencingutm.stagetable in
stage_idfield default value:This commit prevents errors like
psycopg2.errors.UndefinedTable: relation "utm_stage" does not existRef #2372
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr