Skip to content

[DOC] Tip about pip version (no more import error message)#2400

Closed
zeroheure wants to merge 2 commits intoOCA:13.0from
zeroheure:patch-1
Closed

[DOC] Tip about pip version (no more import error message)#2400
zeroheure wants to merge 2 commits intoOCA:13.0from
zeroheure:patch-1

Conversation

@zeroheure
Copy link

Explain why there OpenUpgrade can't find libopenupgrade : install libopenupgrade with the right pip version.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Explain why there OpenUpgrade can't find libopenupgrade : install libopenupgrade with the right pip version.
@zeroheure zeroheure changed the title Tip about pip version (no more import error message) [DOC] Tip about pip version (no more import error message) Aug 28, 2020
@pedrobaeza
Copy link
Member

More than that, I would only change upper line putting pip/pip3 instead of just pip

@zeroheure
Copy link
Author

Yes, I understand the point, but you are a python dev. While I can see in bug reports here and elsewhere that those new to Python doesn't know that pip can be very specific to a version.

From a sysadmin like me, the web page linked in my PR was a very important explanation to what can happened. Actualy I was facing the problem of import not finding the openupgradelib. I've read many report with answers that never explained what happened, but only how to fix.

@pedrobaeza
Copy link
Member

Honestly filling this guide with things that belongs to other guides (like "how to install Python libraries through pip") is not the approach to follow. Giving the tip of using pip or pip3, you can try both and don't make this documentation for what is not intended, as others can ask about including "how to deploy OpenUpgrade", "how to install Ubuntu for putting OpenUpgrade", etc.

Do you get my whole point?

@zeroheure
Copy link
Author

I got it. I will change the PR.

But again, OpenUpgrade is also used by sysadmin. May be we should add a short paragraph into Introduction saying that a bit of Python and Postgresql knowledge is required to use it ?

@pedrobaeza
Copy link
Member

OK about adding the section Prerequisites. Anyway, I think pip stuff is also duty of sysadmins. Please also squash the current 2 commits into one with a meaningful commit message.

@zeroheure
Copy link
Author

My idea was also to help fighting stupid bug reports saying "OpenUpgrade can't find libopenupgrade" ;-)

@pedrobaeza
Copy link
Member

Yeah, I know, and that's why I originally add the pip sentence about using latest GitHub version.

@pedrobaeza
Copy link
Member

Are you going to make the requested changes?

@zeroheure
Copy link
Author

Yes I will. I am curently very busy, sorry for the delay.

@legalsylvain legalsylvain added this to the 13.0 milestone Nov 3, 2020
pedrobaeza added a commit that referenced this pull request Feb 20, 2021
Courtesy of zeroheure in #2400
@pedrobaeza
Copy link
Member

Directly commited in 776383d for not having this PR more time opened.

@pedrobaeza pedrobaeza closed this Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants