Skip to content

[16.0][FIX] account_invoice_supplier_self_invoice: use name over ref in reports#2248

Open
nicolas-delbovier-acsone wants to merge 2 commits intoOCA:16.0from
acsone:16.0-fix-account_invoice_supplier_self_invoice-always-display-name-on-self-invoice
Open

[16.0][FIX] account_invoice_supplier_self_invoice: use name over ref in reports#2248
nicolas-delbovier-acsone wants to merge 2 commits intoOCA:16.0from
acsone:16.0-fix-account_invoice_supplier_self_invoice-always-display-name-on-self-invoice

Conversation

@nicolas-delbovier-acsone
Copy link

@nicolas-delbovier-acsone nicolas-delbovier-acsone commented Jan 30, 2026

The invoice 'ref' field is an external identifier provided by the vendor, not the primary internal identifier for the record. For consistency and proper identification, the 'name' field (Invoice Number) should always be displayed on the report regardless of the document type.

@nicolas-delbovier-acsone
Copy link
Author

@jbaudoux

Copy link

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better change xpath position="replace" by position="before" and then drop o.name

And also drop the section

 <xpath
            expr="//div[@id='informations']/div[@name='reference']"
            position="attributes"
        >

@jbaudoux
Copy link

cc @Shide

@Shide
Copy link
Contributor

Shide commented Jan 30, 2026

@nicolas-delbovier-acsone Can you provide a video with the process to know how it looks the report?

@Shide
Copy link
Contributor

Shide commented Jan 30, 2026

The report changes positions of partner and company.
The invoice looks like if has been generated by the partner, so the name that displays is the generated invoice number (self-billing number)
I need to test this in a runbot when comes up or you provide a video showing the pdf result

…orts

The invoice 'ref' field is an external identifier provided by the vendor,
not the primary internal identifier for the record. For consistency and
proper identification, the 'name' field (Invoice Number) should always
be displayed on the report regardless of the document type.
@nicolas-delbovier-acsone nicolas-delbovier-acsone force-pushed the 16.0-fix-account_invoice_supplier_self_invoice-always-display-name-on-self-invoice branch from 7df1a75 to f12861f Compare January 30, 2026 12:51
@jbaudoux
Copy link

jbaudoux commented Feb 4, 2026

The report changes positions of partner and company. The invoice looks like if has been generated by the partner, so the name that displays is the generated invoice number (self-billing number) I need to test this in a runbot when comes up or you provide a video showing the pdf result

@Shide This is being addressed here #2254

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants