Skip to content

[18.0][FIX] account_invoice_custom_rounding: keep tax base-line contract#2273

Open
grojof wants to merge 4 commits intoOCA:18.0from
grojof:fix/custom-rounding-missing-record
Open

[18.0][FIX] account_invoice_custom_rounding: keep tax base-line contract#2273
grojof wants to merge 4 commits intoOCA:18.0from
grojof:fix/custom-rounding-missing-record

Conversation

@grojof
Copy link

@grojof grojof commented Feb 21, 2026

Summary

  • Harden tax base line preparation in account_invoice_custom_rounding.
  • Handle missing transient records safely while preserving expected tax computation keys.
  • Add focused tests for missing-record fallback behavior.

Why

Avoid fragile behavior in rounding-related tax computation paths and keep contract stable.

Changes

  • account_invoice_custom_rounding/models/account_tax.py
  • account_invoice_custom_rounding/tests/test_account_invoice_custom_rounding.py

Merge order

3/4 (after PR 1 and PR 2)

Depends on:

@grojof
Copy link
Author

grojof commented Feb 21, 2026

Cross-reference: migration follow-up has been posted on #2063 for rerun with the updated 18.0 context (after #2271-#2274 stabilization).

Ref: #2063 (comment)

@grojof grojof marked this pull request as ready for review February 21, 2026 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant