[18.0][IMP] account_brand: compute account_id at move_line creation#282
Open
[18.0][IMP] account_brand: compute account_id at move_line creation#282
Conversation
Contributor
|
Hi @osi-scampbell, @sbejaoui, |
qgroulard
force-pushed
the
18.0-imp-account_brand_create_move_line-qgr
branch
from
a91f747 to
e16f543
Compare
This module has changed a lot between Odoo versions, some features got lost on the way. The account should be computed when a new move line is added, not only when the onchange triggers on the move. The onchange on the move should trigger if the brand or the company changes.
qgroulard
force-pushed
the
18.0-imp-account_brand_create_move_line-qgr
branch
from
e16f543 to
b44202a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This module has changed a lot between Odoo versions, especially in version 13.0 and 16.0 where the method
_recompute_payment_terms_lines()has been added then removed.I believe some features got lost on the way.
Today I don't understand how it is supposed to work anymore. For me: