[18.0][REF] analytic_brand: make use of account analytic distribution models:#286
Open
marielejeune wants to merge 4 commits intoOCA:18.0from
Open
[18.0][REF] analytic_brand: make use of account analytic distribution models:#286marielejeune wants to merge 4 commits intoOCA:18.0from
marielejeune wants to merge 4 commits intoOCA:18.0from
Conversation
Contributor
|
Hi @sbejaoui, |
marielejeune
force-pushed
the
18.0-analytic_brand-analytic_distribution_model-mle
branch
3 times, most recently
from
2e8bdd6 to
140dfb9
Compare
This was referenced Dec 19, 2025
Add brands as a dimension in account analytic distribution models, instead of defining the analytic distribution directly on the brand. This makes the code more standard, allowing to use the standard flow of analytic distribution models everywhere where they will be used.
…tion models: As brands are a dimension in account analytic distribution models, extend the methods of account.analytic.mixin to make it work for contracts
…on models on account moves
…models on sale orders
marielejeune
force-pushed
the
18.0-analytic_brand-analytic_distribution_model-mle
branch
from
140dfb9 to
cfd61d2
Compare
|
Works well, unfortunately backporting this to 16.0 implies doing almost completely different modules (-- I have it working! https://github.com/flinq-ingenieria/brand/tree/16.0-analytic_brand-analytic_distribution_model-mle) as base methods differs too much |
|
This PR significantly improves the integration of brand with analytic accounting. In my humble opinion, the proposed approach is much closer to the functionality users actually expect. For version 16.0, I proposed a conservative migration that followed the previous behavior adapted to analytic distributions. What to do for version 17 is now up to the community to decide. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add brands as a dimension in account analytic distribution models, instead of defining the analytic distribution directly on the brand. This makes the code more standard, allowing to use the standard flow of analytic distribution models everywhere where they will be used.
This PR contains several commits:
analytic_brandto include brands as a dimension in analytic distribution models. Include a migration script for existing analytic distributions defined on brands.contract_brandto make use of the standard analytic distribution models on contracts.account_analytic_brandto make use of the standard analytic distribution models on account moves.sale_analytic_brandto make use of the standard analytic distribution models on sale orders.