[16.0][FIX] brand: Enable overloading of res.brand.mixin views#289
Open
emiliesoutiras wants to merge 1 commit intoOCA:16.0from
Open
[16.0][FIX] brand: Enable overloading of res.brand.mixin views#289emiliesoutiras wants to merge 1 commit intoOCA:16.0from
emiliesoutiras wants to merge 1 commit intoOCA:16.0from
Conversation
Contributor
|
Hi @sbejaoui, |
emiliesoutiras
force-pushed
the
16.0-brand_fix_get_view
branch
from
811e8e3 to
dd93417
Compare
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the get_view() function in the res.brand.mixin template, all view overrides for the brand_id field are systematically overwritten by the Python definition of the field.
As a result, the sale_brand.view_order_form_brand view is useless because the definition of the SaleOrder.brand_id field already sets it to read-only in all states other than ‘draft’.
This proposal intends to make the "readonly" attribute of the brand_id field in views overridable via a Python function.