Open
Conversation
chienandalu
force-pushed
the
16.0-add-delivery_fee
branch
from
e7bb010 to
3be0642
Compare
EmilioPascual
approved these changes
Jan 23, 2026
Contributor
EmilioPascual
left a comment
EmilioPascual
left a comment
There was a problem hiding this comment.
Wonderful module. A minor comment, in no case blocking
| inherit_id="delivery.report_delivery_document2" | ||
| > | ||
| <xpath expr="//div[hasclass('page')]" position="inside"> | ||
| <t t-set="fee_product" t-value="o.carrier_id.fee_product_id" /> |
Contributor
There was a problem hiding this comment.
Perhaps you could create a template and use it in both reports. They are 99% identical. In any case, it works the same way.
chienandalu
force-pushed
the
16.0-add-delivery_fee
branch
from
3be0642 to
aabde50
Compare
Andrii9090-tecnativa
approved these changes
Jan 27, 2026
Andrii9090-tecnativa
left a comment
Andrii9090-tecnativa
left a comment
There was a problem hiding this comment.
Code & funcional review 👍
Contributor
|
This PR has the |
Shide
approved these changes
Jan 27, 2026
chienandalu
force-pushed
the
16.0-add-delivery_fee
branch
from
aabde50 to
b254fc4
Compare
Open
1 task
MT-13311
chienandalu
force-pushed
the
16.0-add-delivery_fee
branch
from
b254fc4 to
d87070e
Compare
chienandalu
force-pushed
the
16.0-add-delivery_fee
branch
2 times, most recently
from
a5682b0 to
e9fe5f4
Compare
chienandalu
force-pushed
the
16.0-add-delivery_fee
branch
from
e9fe5f4 to
2c577dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.loom.com/share/93fad82c79284f2a83fa816955164763
cc @moduon MT-13311