[18.0][IMP] delivery_ups_oca: Save the tracking response#1109
Open
carlos-lopez-tecnativa wants to merge 2 commits intoOCA:18.0from
Open
[18.0][IMP] delivery_ups_oca: Save the tracking response#1109carlos-lopez-tecnativa wants to merge 2 commits intoOCA:18.0from
carlos-lopez-tecnativa wants to merge 2 commits intoOCA:18.0from
Conversation
pedrobaeza
reviewed
Feb 5, 2026
Member
pedrobaeza
left a comment
There was a problem hiding this comment.
Should the whole response be stored? What are the extra data that are not decoded on the later code?
4e92ae1 to
8d22984
Compare
Contributor
Author
I do not know exactly which JSON key contains the tracking information because UPS does not generate a POD, so I think it is better to store the entire response so that we can later generate a report or something based on this field. The current tracking information is only saved in a text field and cannot be manipulated. |
Member
|
Yeah, but if the tracking information is enough, the rest is not needed, just junk, but well, as you prefer. |
8d22984 to
ecf8ec7
Compare
ecf8ec7 to
2f74178
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on:
TT59692
@Tecnativa @sergio-teruel @pedrobaeza could you please review this?