[18.0][IMP] delivery_ups_oca: Convert label from GIF to PDF#1127
Open
carlos-lopez-tecnativa wants to merge 1 commit intoOCA:18.0from
Open
[18.0][IMP] delivery_ups_oca: Convert label from GIF to PDF#1127carlos-lopez-tecnativa wants to merge 1 commit intoOCA:18.0from
carlos-lopez-tecnativa wants to merge 1 commit intoOCA:18.0from
Conversation
UPS can return the label in GIF format instead of PDF. When trying to print the image directly from the attachment using the base_report_to_printer module, it is not possible because GIF is not supported. In this case, convert the label from GIF to PDF.
Contributor
Author
|
I noticed that this PR #1113 adds a similar feature, but with more changes. In the future, they could be unified. @sudhir-erpharbor, could you please review this PR as well while your PR is being finalized? |
pedrobaeza
reviewed
Feb 27, 2026
Comment on lines
+172
to
+173
| label["format_code"] = "PDF" | ||
| format_code = "PDF" |
Member
There was a problem hiding this comment.
No need to do these 2 variable assignment, as it's not being used further.
Suggested change
| label["format_code"] = "PDF" | |
| format_code = "PDF" |
Contributor
Author
There was a problem hiding this comment.
No need to do these 2 variable assignment, as it's not being used further.
Are used in the attachment_name
Member
There was a problem hiding this comment.
OK, but only the second one. And taking the occasion, I don't usually like extensions in upper, so it may be changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UPS can return the label in GIF format instead of PDF. When trying to print the image directly from the attachment using the base_report_to_printer module, it is not possible because GIF is not supported. In this case, convert the label from GIF to PDF.
TT58440
@Tecnativa @pedrobaeza @carlosdauden @sergio-teruel could you please review this?