[18.0][MIG] delivery_carrier_pricelist: Migration to 18.0 by chaule97 · Pull Request #920 · OCA/delivery-carrier

chaule97 · 2024-12-25T11:24:42Z

Since the current delivery module depends on sale instead of sale_stock, I need to update the delivery_carrier_pricelist module to depend on stock_delivery instead of delivery.

New module allowing to compute a delivery cost based on the sales order pricelist. Most of the code of the module is to update the many 'attrs' of the 'delivery' module which have domains based on the "delivery_type" field and cannot be extended in XML without breaking compatibility. When using an external provider (such as DHL, UPS), the "Pricelist" provider cannot be used. In this case, the invoice policy, which is by default "Estimate" or "Real" has a third option "Pricelist Cost". This option would not make sense with "Estimate" or "Real", which is why this field is used.

Previous implementation was writing _every_ time on the carrier for _every_ price compute request. This was causing many write conflicts.

Currently translated at 100.0% (12 of 12 strings) Translation: delivery-carrier-14.0/delivery-carrier-14.0-delivery_carrier_pricelist Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-14-0/delivery-carrier-14-0-delivery_carrier_pricelist/es/

jbaudoux

Some rewording

jbaudoux · 2024-12-30T19:41:33Z

delivery_carrier_pricelist/__manifest__.py

+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
+{
+    "name": "Shipping Method Pricelist",
+    "summary": "Compute method method fees based on the product's pricelist.",


Suggested change

"summary": "Compute method method fees based on the product's pricelist.",

"summary": "Compute delivery method price based on the product's pricelist.",

jbaudoux · 2024-12-30T19:43:24Z

delivery_carrier_pricelist/readme/DESCRIPTION.md

@@ -0,0 +1,13 @@
+Compute shipping methods fees based on Product Pricelists.


Suggested change

Compute shipping methods fees based on Product Pricelists.

Compute the delivery method price based on its related delivery product price according to the sales order pricelist.

jbaudoux · 2024-12-30T19:44:40Z

delivery_carrier_pricelist/readme/DESCRIPTION.md

+Compute shipping methods fees based on Product Pricelists.
+
+It allows to have different pricing per customer, prices depending on
+dates, ... The pricelist based cost is computed from the shipping


Suggested change

dates, ... The pricelist based cost is computed from the shipping

dates, ... The pricelist based cost is computed from the delivery

jbaudoux · 2024-12-30T19:46:52Z

delivery_carrier_pricelist/models/delivery_carrier.py

+        selection_add=[("pricelist", "Pricelist Cost")],
+        ondelete={"pricelist": "set default"},
+        help="Estimated Cost: the customer will be invoiced the estimated"
+        " cost of the shipping.\n"
+        "Real Cost: the customer will be invoiced the real cost of the"
+        " shipping, the cost of the shipping will be updated on the"
+        " SO after the delivery.\n"
+        "Pricelist Cost: the customer will be invoiced the price of the "
+        "product based on the pricelist of the sales order. The provider's "
+        "cost is ignored.",


Suggested change

selection_add=[("pricelist", "Pricelist Cost")],

ondelete={"pricelist": "set default"},

help="Estimated Cost: the customer will be invoiced the estimated"

" cost of the shipping.\n"

"Real Cost: the customer will be invoiced the real cost of the"

" shipping, the cost of the shipping will be updated on the"

" SO after the delivery.\n"

"Pricelist Cost: the customer will be invoiced the price of the "

"product based on the pricelist of the sales order. The provider's "

"cost is ignored.",

selection_add=[("pricelist", "Delivery Product Price")],

ondelete={"pricelist": "set default"},

help="Estimated Cost: the customer will be invoiced the estimated"

" cost of the shipping.\n"

"Real Cost: the customer will be invoiced the real cost of the"

" shipping, the cost of the shipping will be updated on the"

" SO after the delivery.\n"

"Delivery Product Price: the customer will be invoiced the price of the "

"related delivery product based on the pricelist of the sales order. The provider's "

"cost is ignored.",

jbaudoux · 2024-12-30T19:47:44Z

delivery_carrier_pricelist/__manifest__.py

+# Copyright 2020 Camptocamp
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
+{
+    "name": "Shipping Method Pricelist",


Suggested change

"name": "Shipping Method Pricelist",

"name": "Delivery Method Pricelist",

jbaudoux · 2024-12-31T12:06:46Z

/ocabot migration delivery_carrier_pricelist

jbaudoux · 2024-12-31T12:06:57Z

/ocabot merge nobump

OCA-git-bot · 2024-12-31T12:07:04Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-920-by-jbaudoux-bump-nobump, awaiting test results.

Signed-off-by jbaudoux

OCA-git-bot · 2024-12-31T12:11:55Z

It looks like something changed on 18.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 18.0-ocabot-merge-pr-920-by-jbaudoux-bump-nobump, awaiting test results.

OCA-git-bot · 2024-12-31T12:16:52Z

Congratulations, your PR was merged at 22534cc. Thanks a lot for contributing to OCA. ❤️

Guewen Baconnier and others added 15 commits December 24, 2024 15:38

[MIG] delivery_carrier_pricelist: Migration to 14.0

3a6d484

[UPD] Update delivery_carrier_pricelist.pot

2bfcd65

[UPD] README.rst

8d6b691

[ADD] icon.png

3210369

[FIX] delivery_carrier_pricelist: test wizard correct price

405e3d7

delivery_carrier_pricelist 14.0.1.0.1

9f140bd

delivery_carrier_pricelist: rework tests

d726b51

delivery_carrier_pricelist: fix concurrency errors

e7adead

Previous implementation was writing _every_ time on the carrier for _every_ price compute request. This was causing many write conflicts.

delivery_carrier_pricelist 14.0.1.0.2

4fe778b

[UPD] README.rst

7ea30e6

Added translation using Weblate (Spanish)

07e6029

[16.0][MIG] delivery_carrier_pricelist: migration to version 16.0

0a60624

[IMP] delivery_carrier_pricelist: pre-commit auto fixes

2529f99

chaule97 closed this Dec 25, 2024

chaule97 reopened this Dec 25, 2024

chaule97 marked this pull request as draft December 25, 2024 11:29

chaule97 changed the title ~~[18.0][MIG] delivery_package_fee: Migration to 18.0~~ [18.0][MIG] delivery_carrier_pricelist: Migration to 18.0 Dec 25, 2024

chaule97 force-pushed the 18.0-mig-delivery_carrier_pricelist branch 3 times, most recently from 311f11b to 6bff3f5 Compare December 27, 2024 05:12

chaule97 marked this pull request as ready for review December 27, 2024 05:13

jbaudoux reviewed Dec 30, 2024

View reviewed changes

[MIG] delivery_carrier_pricelist: Migration to 18.0

3868e22

chaule97 force-pushed the 18.0-mig-delivery_carrier_pricelist branch from 6bff3f5 to 3868e22 Compare December 31, 2024 02:09

chaule97 requested a review from jbaudoux December 31, 2024 02:12

jbaudoux approved these changes Dec 31, 2024

View reviewed changes

ajaniszewska-dev approved these changes Dec 31, 2024

View reviewed changes

OCA-git-bot added the approved label Dec 31, 2024

OCA-git-bot added this to the 18.0 milestone Dec 31, 2024

OCA-git-bot mentioned this pull request Dec 31, 2024

Migration to version 18.0 #889

Open

42 tasks

OCA-git-bot added a commit that referenced this pull request Dec 31, 2024

Merge PR #920 into 18.0

0c503ca

Signed-off-by jbaudoux

OCA-git-bot added the bot is merging ⏳ label Dec 31, 2024

OCA-git-bot merged commit d9049f6 into OCA:18.0 Dec 31, 2024
4 of 6 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Dec 31, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[18.0][MIG] delivery_carrier_pricelist: Migration to 18.0#920

[18.0][MIG] delivery_carrier_pricelist: Migration to 18.0#920
OCA-git-bot merged 16 commits intoOCA:18.0from
chaule97:18.0-mig-delivery_carrier_pricelist

chaule97 commented Dec 25, 2024 •

edited

Loading

Uh oh!

jbaudoux left a comment

Uh oh!

jbaudoux Dec 30, 2024

Uh oh!

jbaudoux Dec 30, 2024

Uh oh!

jbaudoux Dec 30, 2024

Uh oh!

jbaudoux Dec 30, 2024

Uh oh!

jbaudoux Dec 30, 2024

Uh oh!

jbaudoux commented Dec 31, 2024

Uh oh!

jbaudoux commented Dec 31, 2024

Uh oh!

OCA-git-bot commented Dec 31, 2024

Uh oh!

OCA-git-bot commented Dec 31, 2024

Uh oh!

Uh oh!

OCA-git-bot commented Dec 31, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

	"summary": "Compute method method fees based on the product's pricelist.",
	"summary": "Compute delivery method price based on the product's pricelist.",

		@@ -0,0 +1,13 @@
		Compute shipping methods fees based on Product Pricelists.

	Compute shipping methods fees based on Product Pricelists.
	Compute the delivery method price based on its related delivery product price according to the sales order pricelist.

	dates, ... The pricelist based cost is computed from the shipping
	dates, ... The pricelist based cost is computed from the delivery

	"name": "Shipping Method Pricelist",
	"name": "Delivery Method Pricelist",

Uh oh!

Conversation

chaule97 commented Dec 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jbaudoux left a comment

Choose a reason for hiding this comment

Uh oh!

jbaudoux Dec 30, 2024

Choose a reason for hiding this comment

Uh oh!

jbaudoux Dec 30, 2024

Choose a reason for hiding this comment

Uh oh!

jbaudoux Dec 30, 2024

Choose a reason for hiding this comment

Uh oh!

jbaudoux Dec 30, 2024

Choose a reason for hiding this comment

Uh oh!

jbaudoux Dec 30, 2024

Choose a reason for hiding this comment

Uh oh!

jbaudoux commented Dec 31, 2024

Uh oh!

jbaudoux commented Dec 31, 2024

Uh oh!

OCA-git-bot commented Dec 31, 2024

Uh oh!

OCA-git-bot commented Dec 31, 2024

Uh oh!

Uh oh!

OCA-git-bot commented Dec 31, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

chaule97 commented Dec 25, 2024 •

edited

Loading