Skip to content

[18.0][MIG] sale_order_warehouse_from_delivery_carrier: Migration to 18.0#930

Merged
OCA-git-bot merged 7 commits intoOCA:18.0from
HeliconiaIO:18.0-mig-sale_order_warehouse_from_delivery_carrier
Oct 8, 2025
Merged

[18.0][MIG] sale_order_warehouse_from_delivery_carrier: Migration to 18.0#930
OCA-git-bot merged 7 commits intoOCA:18.0from
HeliconiaIO:18.0-mig-sale_order_warehouse_from_delivery_carrier

Conversation

@BhaveshHeliconia
Copy link
Contributor

@BhaveshHeliconia BhaveshHeliconia commented Jan 8, 2025

No description provided.

@BhaveshHeliconia BhaveshHeliconia mentioned this pull request Jan 8, 2025
Open
42 tasks
@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-sale_order_warehouse_from_delivery_carrier branch from 6f1025c to 0a384ff Compare January 8, 2025 12:26
geomer198 and others added 6 commits March 31, 2025 17:35
@geomer198 @BhaveshHeliconia
[ADD] sale_order_warehouse_from_delivery_carrier: Module added.
24117fb 
[UPD] Update sale_order_warehouse_from_delivery_carrier.pot

[BOT] post-merge updates
@mymage @BhaveshHeliconia
Added translation using Weblate (Italian)
08e6f9d 
Translated using Weblate (Italian)

Currently translated at 100.0% (4 of 4 strings)

Translation: delivery-carrier-16.0/delivery-carrier-16.0-sale_order_warehouse_from_delivery_carrier
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-16-0/delivery-carrier-16-0-sale_order_warehouse_from_delivery_carrier/it/
@sanderlienaerts @BhaveshHeliconia
[IMP] sale_order_warehouse_from_delivery_carrier: black, isort, prettier
a1e40fd
@sanderlienaerts @BhaveshHeliconia
[MIG] sale_order_warehouse_from_delivery_carrier: Migration to 17.0
c693814
@BhaveshHeliconia
[UPD] Update sale_order_warehouse_from_delivery_carrier.pot
3334908
@BhaveshHeliconia
[IMP] sale_order_warehouse_from_delivery_carrier: pre-commit auto fixes
468401b
@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-sale_order_warehouse_from_delivery_carrier branch from 0a384ff to 1d326a7 Compare March 31, 2025 12:05
@github-actions
Copy link

github-actions bot commented Aug 3, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 3, 2025
@hparfr
Copy link
Contributor

hparfr commented Aug 4, 2025

/ocabot migration sale_order_warehouse_from_delivery_carrier

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Aug 4, 2025
@hparfr
Copy link
Contributor

hparfr commented Aug 4, 2025

@geomer198 @sanderlienaerts @ByteMeAsap please review this migration

ByteMeAsap
ByteMeAsap reviewed Aug 4, 2025
View reviewed changes
sale_order_warehouse_from_delivery_carrier/tests/test_module_flow.py
msg="Order Warehouse must be equal to 'Test Warehouse #1'",
)
self.sale_order.action_confirm()
self.sale_order.order_line.filtered(
Copy link

@ByteMeAsap ByteMeAsap Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this change necessary to add? If yes, can you please in brief why its needed

Copy link
Contributor Author

@BhaveshHeliconia BhaveshHeliconia Aug 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ByteMeAsap : Yes, this change is necessary because without it, the test case passes locally but fails in CI with the following error:

odoo.exceptions.UserError: You can not update the shipping costs on an order where it was already invoiced!

This occurs during test_sale_order_carrier_id_confirmation when confirming the shipping method. The change ensures the test runs consistently across environments.

Copy link

@ByteMeAsap ByteMeAsap Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 10, 2025
@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-sale_order_warehouse_from_delivery_carrier branch from 1d326a7 to 4e4b732 Compare August 26, 2025 09:06
@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-sale_order_warehouse_from_delivery_carrier branch from 4e4b732 to 95bfebf Compare August 26, 2025 09:17
ByteMeAsap
ByteMeAsap approved these changes Aug 26, 2025
View reviewed changes
Copy link

@ByteMeAsap ByteMeAsap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rousseldenis
Copy link
Contributor

rousseldenis commented Oct 8, 2025

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Oct 8, 2025

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-930-by-rousseldenis-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c0b06a4 into OCA:18.0 Oct 8, 2025
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Oct 8, 2025

Congratulations, your PR was merged at 48249b0. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hparfr hparfr hparfr approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

+1 more reviewer

@ByteMeAsap ByteMeAsap ByteMeAsap approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉

Projects

None yet

Milestone

18.0

Development

Successfully merging this pull request may close these issues.

8 participants

@BhaveshHeliconia @hparfr @rousseldenis @OCA-git-bot @ByteMeAsap @geomer198 @mymage @sanderlienaerts