[18.0][MIG] dms: Migration to 18.0#399
Conversation
versions of muk_dms than 12.0.2.0.0. Tested from 1.2.4 version.
In v13, this test is programmed in such a way that the demo user is supposed to be able to copy that subdirectory: https://github.com/OCA/dms/blob/c3f802db43362127e70d8c7b4987fb71d4c1f01c/dms/tests/test_directory.py#L40 However, in OCA#7 that test was modified indicating that demo user didn't have permissions to do that: https://github.com/OCA/dms/blob/e3b6d8d24534f2a68bfb88e310cc70cefe46bb64/dms/tests/test_directory.py#L39 Rolling back that change to ensure premissions remain the same in both versions of the module. Also changing the directory to test to ensure it contains no SVG files, whose detection seems to differ among environments, and which have some specific permission restrictions that can make the modified test fail or pass. @Tecnativa TT25645
victoralmau
force-pushed
the
18.0-mig-dms
branch
4 times, most recently
from
3183cb6 to
ef95303
Compare
|
/ocabot migration dms |
victoralmau
force-pushed
the
18.0-mig-dms
branch
from
ef95303 to
c4c959e
Compare
Co-authored-by: kobros-tech TT55505
victoralmau
force-pushed
the
18.0-mig-dms
branch
from
c4c959e to
1f08ada
Compare
|
It is now ready to review. |
|
@xaviedoanhduy @kobros-tech can you guys recheck this iteration prior to data migration testing? |
yes, I was going to ask about the update and continue migration. |
|
thank you for giving time and effort, you are the best to migrate this work and I hope if your contribution did help. the kanban view is updated, and I see the module behaviour is almost the same as in previous versions. I hope my own comments and still haping them, so continue to migration and for me I can add my work on to of yours. We are adding a new module that needs privacy for each portal user alone, so each one can see their own tax exemption files. I wish if this feature was available as a default. but this one and sharing feature will be needed with the new module. Maybe I need your opinion to connect between dms and sign_oca, I will have to as to connect between dms and exemption and between sign and exemption alone is fine. but both can interfer and need management, in a module controlling them all. For this I will open a new issue for discussion and opinions. |
kobros-tech
left a comment
kobros-tech
left a comment
There was a problem hiding this comment.
although the readme is deprecated in the part of sharing files via a token from a button in the file form view, but as long as I am adding this feature again so no worries.
thanks.
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 1d0405c. Thanks a lot for contributing to OCA. ❤️ |
it is good to have dms merged but what about my inquiries? do they worth to have replied or suggestion to open PR for them? |
|
You can open an issue or the PR on top of this and let's discuss about that. The clearer you are exposing the changes, the reasons, cons and pros, the better to pipeline its way to be merged. Take into account that some breaking changes may be under a configurable option, so that people can choose to continue with their current behavior or the new. |
|
very nice, I am working on that to produce smooth connection between all projects without any conflict. |
20 participants
Supersedes #385
Changes done:
_check_recursion()method to_has_cycle()check_access_rights()+check_access_rule()tocheck_access()+ adaptations._filter_access_rules()+_filter_access_rules_python()methods to_filtered_access()+ adaptations./** @odoo-module **/from.jsfiles.treetolistt-name=“kanban-box”tot-name=“card”.<div class=“oe_chatter”>to<chatter />copy()methodMigration to 18.0
@Tecnativa TT55505