[18.0][IMP] dms_field: Use ir.assets for xml to add the sequence and avoid race condition with hr_holidays accrual plan#448
Merged
OCA-git-bot merged 1 commit intoOCA:18.0from Oct 3, 2025
Conversation
Member
|
Can't you trick the position of loading here? Line 27 in f7bacd4 |
…race condition with hr_holidays accrual plan
Member
Author
|
Not directly, but by using ir.assets I am able to do that. WDYT? |
Member
|
@CarlosRoca13 I think you did the asset thing. Can you check if this is correct? |
Contributor
|
What a great day to merge this nice PR. Let's do it! |
pedrobaeza
changed the title
Contributor
|
Congratulations, your PR was merged at fe4a576. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have detected that the dms_field way of defining the field is providing issues with hr_holidays on the view accural. If hr_holidays and dms_field are both installed and we try to access accruals, we receive the following error:
this comes from the definition of accrual plan widget in 18 (fixed in 19). The way I found to solve it is to move the DMSList in this case too.
https://github.com/odoo/odoo/blob/18.0/addons/hr_holidays/static/src/xml/x2many_field.xml
It affects 17.0 too, but not 16.0