[16.0][ADD] helpdesk_mgmt_purchase: links purchase orders and helpdesk tickets.#879
Open
nicolas-delbovier-acsone wants to merge 7 commits intoOCA:16.0from
Open
[16.0][ADD] helpdesk_mgmt_purchase: links purchase orders and helpdesk tickets.#879nicolas-delbovier-acsone wants to merge 7 commits intoOCA:16.0from
nicolas-delbovier-acsone wants to merge 7 commits intoOCA:16.0from
Conversation
nicolas-delbovier-acsone
force-pushed
the
16.0-add-helpdesk-mgmt-purchase
branch
2 times, most recently
from
a0a0bb0 to
42ffdbc
Compare
nicolas-delbovier-acsone
changed the title
lmignon
suggested changes
Jan 9, 2026
| @api.depends("ticket_ids") | ||
| def _compute_ticket_count(self): | ||
| for order in self: | ||
| order.ticket_count = len(order.ticket_ids) |
There was a problem hiding this comment.
@nicolas-delbovier-acsone you should use a read_groupto avoid perf issue if the field is accessed on a large recordsed....
nihelgabsi-acsone
approved these changes
Jan 16, 2026
nihelgabsi-acsone
force-pushed
the
16.0-add-helpdesk-mgmt-purchase
branch
from
e465d5b to
c69e5c2
Compare
lmignon
suggested changes
Mar 12, 2026
lmignon
left a comment
lmignon
left a comment
There was a problem hiding this comment.
@nicolas-delbovier-acsone please make sure to fill in the README.rst files with the module info and remove any empty ones.
…ields to improve perf
The button to view Helpdesk tickets from a Purchase Order was incorrectly passing a 'default_sale_order_id' in the action context due to a copy-paste error from the sales module. This caused new tickets created from a PO view to be linked to an unrelated Sale Order.
Shifting the action logic to Python facilitates dynamic customization. This approach allows inheriting modules to override or extend the action via super(), avoiding the limitations and complexity of XML xpath inheritance for conditional logic
Following the removal of the erroneous 'default_sale_order_id' from the purchase action, this commit strengthens the test suite to prevent regressions. The test logic now explicitly validates the content of the action context. This ensures that: - The expected Purchase Order ID is present. - No unrelated context keys (like 'default_sale_order_id') are leaking into the view from inherited methods or copy-paste errors.
nicolas-delbovier-acsone
force-pushed
the
16.0-add-helpdesk-mgmt-purchase
branch
from
3d6ed92 to
de624f4
Compare
lmignon
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.