Skip to content

[17.0][IMP] payment_redsys: soporte para pre-autorización de cobro#4205

Open
acysos wants to merge 1 commit intoOCA:17.0from
acysos:17.0-payment_redsys-post_payment
Open

[17.0][IMP] payment_redsys: soporte para pre-autorización de cobro#4205
acysos wants to merge 1 commit intoOCA:17.0from
acysos:17.0-payment_redsys-post_payment

Conversation

@acysos
Copy link
Member

@acysos acysos commented May 26, 2025

Hola,

Implementación para añadir un nuevo tipo de operación. Este permite autorizar un cobro a una tarjeta pero no se cobra hasta que se ejecute luego en el pago. Esta función se utiliza cuando los pedidos online tienen un importe variable, por ejemplo, comprar en función del peso de fruta o verdura. Cuando se realiza una reserva y se cobra días antes de que se ejecute, por ejemplo, hoteles.

Saludos

@acysos acysos force-pushed the 17.0-payment_redsys-post_payment branch 5 times, most recently from c3a9c12 to c3ccb1c Compare May 28, 2025 17:37
@acysos acysos requested a review from Copilot May 28, 2025 17:53
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds pre-authorization support to the Redsys payment integration, enabling a two-step authorize-then-capture workflow.

  • UI: Introduce “Authorize Amount” button and related fields on the payment form
  • Documentation: Update configuration guides to cover transaction type 1 for pre-authorization
  • Logic: Extend account.payment with a redsys_authorize_amount method and new fields; register new view in manifest

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
views/account_payment_view.xml Added button and fields for pre-authorization UI
readme/CONFIGURE.md & README.rst Clarified transaction type “1” in setup docs
models/payment_provider.py Enhanced redsys_transaction_type field with help
models/account_payment.py Implemented pre-authorization logic and new fields
manifest.py Included new view in module data
Comments suppressed due to low confidence (2)

payment_redsys/models/account_payment.py:31

  • Consider adding unit tests for redsys_authorize_amount to cover success, validation errors, and error handling paths.
def redsys_authorize_amount(self):

payment_redsys/models/account_payment.py:59

  • The transaction type is hardcoded to "2" instead of using provider.redsys_transaction_type, causing mismatch between configuration and request.
"Ds_Merchant_TransactionType": "2",

@acysos acysos force-pushed the 17.0-payment_redsys-post_payment branch from 862ffef to b1bc47a Compare May 28, 2025 21:21
@acysos acysos requested a review from DarioLodeiros June 3, 2025 15:46
Copy link
Member

@DarioLodeiros DarioLodeiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical review Ok!
Functional: Review the visual elements related to the account.payment form confirmations so that they are only visible for payments that have an associated transaction with the provider Redsys of type 1.

@acysos acysos force-pushed the 17.0-payment_redsys-post_payment branch from b1bc47a to e0b9002 Compare June 14, 2025 18:24
@acysos
Copy link
Member Author

acysos commented Jun 14, 2025

Technical review Ok! Functional: Review the visual elements related to the account.payment form confirmations so that they are only visible for payments that have an associated transaction with the provider Redsys of type 1.

Resuelto.

@acysos acysos force-pushed the 17.0-payment_redsys-post_payment branch 2 times, most recently from 7f0e14b to 6c2776b Compare June 14, 2025 20:36
@pedrobaeza pedrobaeza added this to the 17.0 milestone Jun 21, 2025
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gracias por la mejora, Ignacio. Todo el código añadido no tiene cobertura de test, lo que lo hace bastante frágil a posibles regresiones. ¿Podríais añadir código de test para cubrirlo?

@pedrobaeza pedrobaeza changed the title [IMP] payment_redsys: soporte para pre-autorización de cobro [17.0][IMP] payment_redsys: soporte para pre-autorización de cobro Jun 21, 2025
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added stale PR/Issue without recent activity, it'll be soon closed automatically. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Oct 26, 2025
@acysos acysos force-pushed the 17.0-payment_redsys-post_payment branch 9 times, most recently from 2a19156 to 0a900a2 Compare January 14, 2026 21:20
@acysos acysos force-pushed the 17.0-payment_redsys-post_payment branch 9 times, most recently from 6e7850b to cd58116 Compare January 15, 2026 12:39
[IMP] payment_redsys: soporte para pre-autorización de cobro

[IMP] payment_redsys: soporte para pre-autorización de cobro

[IMP] payment_redsys: soporte para pre-autorización de cobro

[IMP] payment_redsys: soporte para pre-autorización de cobro

[IMP] payment_redsys: soporte para pre-autorización de cobro

[IMP] payment_redsys: soporte para pre-autorización de cobro

[IMP] payment_redsys: soporte para pre-autorización de cobro

[IMP] payment_redsys: soporte para pre-autorización de cobro

[IMP] payment_redsys: soporte para pre-autorización de cobro

[IMP] payment_redsys: soporte para pre-autorización de cobro

[IMP] payment_redsys: soporte para pre-autorización de cobro

[IMP] payment_redsys: soporte para pre-autorización de cobro

[IMP] payment_redsys: soporte para pre-autorización de cobro

[IMP] payment_redsys: soporte para pre-autorización de cobro

[IMP] payment_redsys: soporte para pre-autorización de cobro

[IMP] payment_redsys: soporte para pre-autorización de cobro

[IMP] payment_redsys: soporte para pre-autorización de cobro

[IMP] payment_redsys: soporte para pre-autorización de cobro

[IMP] payment_redsys: soporte para pre-autorización de cobro

[IMP] payment_redsys: soporte para pre-autorización de cobro

[IMP] payment_redsys: soporte para pre-autorización de cobro

[IMP] payment_redsys: soporte para pre-autorización de cobro

[IMP] payment_redsys: soporte para pre-autorización de cobro

[IMP] payment_redsys: soporte para pre-autorización de cobro

[IMP] payment_redsys: soporte para pre-autorización de cobro

[IMP] payment_redsys: soporte para pre-autorización de cobro

[IMP] payment_redsys: soporte para pre-autorización de cobro

[IMP] payment_redsys: soporte para pre-autorización de cobro

[IMP] payment_redsys: soporte para pre-autorización de cobro

[IMP] payment_redsys: soporte para pre-autorización de cobro

[IMP] payment_redsys: soporte para pre-autorización de cobro

[IMP] payment_redsys: soporte para pre-autorización de cobro

[IMP] payment_redsys: soporte para pre-autorización de cobro

[IMP] payment_redsys: soporte para pre-autorización de cobro

[IMP] payment_redsys: soporte para pre-autorización de cobro

[IMP] payment_redsys: soporte para pre-autorización de cobro

[IMP] payment_redsys: soporte para pre-autorización de cobro
@acysos acysos force-pushed the 17.0-payment_redsys-post_payment branch from cd58116 to 2b50b4f Compare January 15, 2026 13:11
@acysos
Copy link
Member Author

acysos commented Jan 15, 2026

Todos verdes.

@acysos acysos added the no stale Use this label to prevent the automated stale action from closing this PR/Issue. label Jan 15, 2026
@acysos acysos removed the no stale Use this label to prevent the automated stale action from closing this PR/Issue. label Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants