[18.0][FIX] l10n_es_*_sii: Do breakdown only when needed and mix services and goods properly by default#4797
Open
pedrobaeza wants to merge 1 commit intoOCA:18.0from
Open
Conversation
4d86a64 to
a53368f
Compare
a53368f to
c9ad03f
Compare
Member
Author
|
@HaraldPanten @almumu @etobella @omar7r este cambio proviene de un error inicial en el SII del PoS cuando se mezclan bienes y servicios, que me ha llevado a tirar del hilo y ver que básicamente se estaba haciendo desglose en cuanto se mezclaban bienes y servicios, cuando según parece, eso no es necesario salvo unos pocos casos, como intra o extra-comunitario. De ahí la gran cantidad de cambios. Voy a seguir probándolo en casos reales, pero por el momento todo es correcto. A ver qué os parece, que con esto la estructura enviada es más simple y menos liosa. |
c9ad03f to
3c182fb
Compare
…nd goods properly by default For simplified invoices, the taxes breakdown is not required, but right now if you make a PoS order mixing goods and services, the dictionary structure is a mix between breakdown and not breakdown. Let's fix it handling properly the no breakdown, and only performing it when needed. But this has led to change the base module, so not doing breakdown on other ocassions that previously were done. TT60718
3c182fb to
425b58c
Compare
Contributor
|
Gracias Pedro, Le echaremos un ojo junto con @ValentinVinagre y te damos feedback. De momento no fusiones 🙏 |
Member
Author
|
Sí, no voy a fusionarlo mientras no haya un poco de pruebas de varios. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For simplified invoices, the taxes breakdown is not required, but right now if you make a PoS order mixing goods and services, the dictionary structure is a mix between breakdown and not breakdown.
Let's fix it handling properly the no breakdown, and only performing it when needed. But this has led to change the base module, so not doing breakdown on other ocassions that previously were done.
@Tecnativa TT60718