[16.0][ADD] billcom_integration by antoniodavid · Pull Request #166 · OCA/l10n-usa

antoniodavid · 2025-11-20T05:50:28Z

jelenapoblet · 2025-11-20T15:30:04Z

To improve clarity, I would like to propose renaming the addon to billcom_integration. The current technical name, billcom, is quite generic and doesn’t clearly communicate the purpose of the module. Using billcom_integration makes it immediately evident that the addon provides an integration with the Bill.com platform.

antoniodavid · 2025-11-27T06:24:55Z

@rrebollo @jelenapoblet @crrodrigueztrujillo guys, reviews needed!!!

rrebollo

In general, the code looks good. It is a huge effort and a valuable asset to contribute to the OCA ecosystem.

Most of my comments are just suggestions; only a minority require action (clarification or small fixes).

However, looking ahead, I am worried about the size of this addon. Maintenance could become a nightmare, and I think we need a strategy to make this manageable. The sheer effort required to review this would be a dealbreaker for the vast majority of the community unless there is an economic incentive to maintain the addon in its current form.

Maybe it can be split, or perhaps the logic could be encapsulated in a library?

rrebollo · 2025-11-27T13:44:03Z

billcom/tests/test_account_payment.py

I'm guessing you left this here when renaming the addon. The full billcom directory should be deleted. Don't you think?

rrebollo · 2025-11-27T22:02:41Z

billcom_integration/controllers/billcom_controller.py

+                )
+            )
+            if move:
+                move.with_context(skip_billcom_sync=True).write({"active": False})


what about posted moves? Is it valid to archive a posted moves?

rrebollo · 2025-11-27T22:05:41Z

billcom_integration/controllers/billcom_controller.py

+                )
+            )
+            if move:
+                move.with_context(skip_billcom_sync=True).write({"active": False})


Suggested change

move.with_context(skip_billcom_sync=True).write({"active": False})

move.with_context(skip_billcom_sync=True).action_archive()

rrebollo · 2025-11-27T22:06:01Z

billcom_integration/controllers/billcom_controller.py

+                )
+            )
+            if move:
+                move.with_context(skip_billcom_sync=True).write({"active": True})


Suggested change

move.with_context(skip_billcom_sync=True).write({"active": True})

move.with_context(skip_billcom_sync=True).action_unarchive()

rrebollo · 2025-11-27T22:07:29Z

billcom_integration/controllers/billcom_controller.py

+                )
+            )
+            if partner:
+                partner.with_context(skip_billcom_sync=True).write({"active": False})


Suggested change

partner.with_context(skip_billcom_sync=True).write({"active": False})

partner.with_context(skip_billcom_sync=True).action_archive()

rrebollo · 2025-11-30T10:39:41Z

billcom_integration/models/billcom_webhook_log.py

+_logger = logging.getLogger(__name__)
+
+
+class BillcomWebhookLog(models.Model):


Webhooks are a built-in (limited feateure in odoo 17.0), thinking in migration. you can checkout also OCA/webhook#13 OCA/webhook#14

rrebollo · 2025-11-30T10:47:05Z

billcom_integration/models/res_partner.py

+        if self.child_ids:
+            for child in self.child_ids:
+                if child.type == "invoice":
+                    billing_address = child
+                elif child.type == "delivery":
+                    shipping_address = child


Suggested change

if self.child_ids:

for child in self.child_ids:

if child.type == "invoice":

billing_address = child

elif child.type == "delivery":

shipping_address = child

for child in self.child_ids:

if child.type == "invoice":

billing_address = child

elif child.type == "delivery":

shipping_address = child

A partner could have multiple invoice and delivery address so ...

rrebollo · 2025-11-30T10:54:37Z

billcom_integration/readme/USAGE.rst

Please provide instructions for configuring the initial API connection, including authentication methods and required credentials.

Add also details on the specific webhooks that need to be configured in your Bill.com account to enable real-time data synchronization.

rrebollo · 2025-11-30T10:56:17Z

billcom_integration/security/billcom_security.xml

I don't see any multicompany rule. Is this intended?

rrebollo · 2025-11-30T11:00:02Z

billcom_integration/wizards/billcom_partner_matching_line.py

+    billcom_partner_phone = fields.Char(string="Bill.com Phone", readonly=True)
+
+    # Multi-currency duplicate handling
+    billcom_ids_json = fields.Text(


Are you storing a json ? why don't use fields.Binary?

jelenapoblet · 2025-11-30T13:18:17Z

In general, the code looks good. It is a huge effort and a valuable asset to contribute to the OCA ecosystem.

Most of my comments are just suggestions; only a minority require action (clarification or small fixes).

However, looking ahead, I am worried about the size of this addon. Maintenance could become a nightmare, and I think we need a strategy to make this manageable. The sheer effort required to review this would be a dealbreaker for the vast majority of the community unless there is an economic incentive to maintain the addon in its current form.

Maybe it can be split, or perhaps the logic could be encapsulated in a library?

This is a valid POV, we need to consider long term maintenance for this integration, it's already in v16 , what about migrations to v17 and v18 ?

jelenapoblet · 2025-12-03T10:08:50Z

To make this more manageable and more “OCA-friendly” long term, we should reduce the surface area of each module. As we already discussed, the right way forward is to split the integration into:

billcom_integration_base

Core models and technical framework
API client / authentication
Shared utilities, error handling, logging, mappers
Generic configuration and hooks

billcom_integration_customers

Customer sync
Customer invoices / credit notes
Customer payments
AR-specific logic

billcom_integration_vendors

Vendor sync
Vendor bills / credit notes
Vendor payments
AP-specific logic

This split will make review and testing more approachable, let users install only what they need, keep the base addon reusable, and lower the maintenance burden in the future.

I’m happy to help refine the boundaries between modules if we move in this direction, but I strongly recommend not merging this as a single, very large addon.

antoniodavid force-pushed the 16.0-add-billcom branch 2 times, most recently from 79b4d72 to a4451ab Compare November 20, 2025 06:38

antoniodavid force-pushed the 16.0-add-billcom branch from a4451ab to 1c095f8 Compare November 20, 2025 23:35

antoniodavid changed the title ~~[16.0][ADD] billcom~~ [16.0][ADD] billcom_integration Nov 20, 2025

antoniodavid force-pushed the 16.0-add-billcom branch 12 times, most recently from a40928e to 594a948 Compare November 27, 2025 03:04

[16.0][ADD] billcom_integration

67825f7

antoniodavid force-pushed the 16.0-add-billcom branch from 594a948 to 67825f7 Compare November 27, 2025 06:18

rrebollo suggested changes Nov 30, 2025

View reviewed changes

	move.with_context(skip_billcom_sync=True).write({"active": False})
	move.with_context(skip_billcom_sync=True).action_archive()

	partner.with_context(skip_billcom_sync=True).write({"active": False})
	partner.with_context(skip_billcom_sync=True).action_archive()

		_logger = logging.getLogger(__name__)


		class BillcomWebhookLog(models.Model):

Uh oh!

Conversation

antoniodavid commented Nov 20, 2025

Uh oh!

jelenapoblet commented Nov 20, 2025

Uh oh!

antoniodavid commented Nov 27, 2025

Uh oh!

rrebollo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jelenapoblet commented Nov 30, 2025

Uh oh!

jelenapoblet commented Dec 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants