Skip to content

[18.0][ADD] rma_inter_company: New module#958

Open
victoralmau wants to merge 1 commit intoOCA:18.0from
Tecnativa:18.0-add-rma_inter_company
Open

[18.0][ADD] rma_inter_company: New module#958
victoralmau wants to merge 1 commit intoOCA:18.0from
Tecnativa:18.0-add-rma_inter_company

Conversation

@victoralmau
Copy link
Copy Markdown
Member

@victoralmau victoralmau commented Feb 24, 2026

New module

Please @pedrobaeza and @carlos-lopez-tecnativa can you review it?

@Tecnativa TT57882

@victoralmau victoralmau force-pushed the 18.0-add-rma_inter_company branch 3 times, most recently from be0f7f3 to a2dfe6f Compare February 24, 2026 12:31
@victoralmau victoralmau changed the title [18.0][ADD] rma_inter_company: New module [18.0][WIP] rma_inter_company: New module Feb 24, 2026
@victoralmau victoralmau force-pushed the 18.0-add-rma_inter_company branch 3 times, most recently from 8ca0468 to 5b3f0f9 Compare February 26, 2026 16:42
@victoralmau victoralmau force-pushed the 18.0-add-rma_inter_company branch 2 times, most recently from b6a3804 to 5075173 Compare March 16, 2026 13:20
@victoralmau victoralmau force-pushed the 18.0-add-rma_inter_company branch 5 times, most recently from 49c3db3 to e0c6ecc Compare March 24, 2026 09:43
Copy link
Copy Markdown
Contributor

@juancarlosonate-tecnativa juancarlosonate-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following the flow and validating the RMA picking in Company A, the following error appears:

Image

@victoralmau victoralmau force-pushed the 18.0-add-rma_inter_company branch 2 times, most recently from 5533ce2 to db9b3a2 Compare March 25, 2026 15:07
@victoralmau victoralmau changed the title [18.0][WIP] rma_inter_company: New module [18.0][ADD] rma_inter_company: New module Mar 25, 2026
@victoralmau victoralmau marked this pull request as ready for review March 25, 2026 16:07
Copy link
Copy Markdown
Contributor

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned internally, with the current settings, where in C1 I configure that this RMA must generate a new RMA in C2, these settings do not allow generating an RMA in C3, for example. In other words, from one company I can generate an RMA to only a single destination company, but if I want to generate an RMA from C1 to C2 or from C1 to C3, it is not possible. I think this intercompany setting is limited.

if purchase_sale_stock_inter_company is used).
""" # noqa: E501
self.ensure_one()
return self.company_id.intercompany_rma_company_id
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I do not set this field and enable the Generate Intercompany RMA field, I get this error.
Image

Image

partner = company.sudo().partner_id
vals = {
"company_id": company.id,
"partner_id": partner.id,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but I understand that the partner must be the partner of the origin company, not the destination company. I created the RMA in San Francisco with customer X. This should generate a new RMA in the Chicago company, but the partner should be San Francisco, not Chicago. Or did I misunderstand the flow?

Image

@victoralmau victoralmau force-pushed the 18.0-add-rma_inter_company branch 5 times, most recently from 5f392bb to 3007dc1 Compare March 30, 2026 07:53
@victoralmau victoralmau force-pushed the 18.0-add-rma_inter_company branch from 3007dc1 to c1bee2d Compare March 30, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants