[IMP] use check-vendor-libs action - #365
Open
hbrunn wants to merge 1 commit into
Open
Conversation
hbrunn
force-pushed
the
master-check-vendor-libs
branch
from
July 31, 2026 14:36
700520d to
406cff1
Compare
yajo
reviewed
Aug 4, 2026
| type: bool | ||
|
|
||
| use_check_vendor_libs: | ||
| default: "{% if odoo_version < 18.0 -%}disabled{% elif odoo_version < 20.0 %}optional{% else %}mandatory{% endif %}" |
Member
There was a problem hiding this comment.
In practice, what's the difference between disabled and optional?
Member
Author
There was a problem hiding this comment.
optional shows you what the checker would complain about, so you can incrementally fix things and turn it to mandatory when all currently existing addons declare the origin of their vendored code
yajo
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds hbrunn/check-vendor-libs as discussed in OCA/odoo-pre-commit-hooks#191.
When applied to the website repository:
I think this should be mandatory for all v20+ repositories so that people can take care of this when migrating to that version and hopefully updating the vendored code anyways. I set the default to disabled for <18 because I don't expect anyone to care for those versions enough to add it there.