-
-
Notifications
You must be signed in to change notification settings - Fork 73
[19.0][MIG] attribute_set #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 19.0
Are you sure you want to change the base?
Conversation
d3445da to
963440b
Compare
14d00bc to
6ab37c5
Compare
|
/ocabot migration |
|
Hi @bosd. Your command failed:
Ocabot commands
More information
|
rvalyi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please do a rebase to use the 18.0 branch as we just merged #192 . Make sure you rebase your 19.0 migration atop of this 18.0 "official" migration. Sorry for the delay.
New organization : - attribute_set (former base_custom_attribute) - product_attribute_set (former pim_custom_attribute but without menus) - pim (The "PIM application" former pim_base) - pim_attrubute_set (depends on product_attribute_set and adds menus in the PIM application)
And small FIX in _build_attribute_field()
[UPD] README.rst [UPD] README.rst
[UPD] README.rst
…d attribute_set [CHG] add required columns on attributes on attribute set form view attribute_set 13.0.1.0.1
As model_id is referring to non accessible models for common users, set a related field in order to be able to use it in views domains. Moreover, add a domain on attribute_set_id field in attribute owner mixin in order to simplify inherited views.
As attribute view building is accessing ir.model records, do it with sudo. [UPD] Update attribute_set.pot [BOT] post-merge updates [UPD] Update attribute_set.pot
Currently translated at 100.0% (125 of 125 strings) Translation: odoo-pim-16.0/odoo-pim-16.0-attribute_set Translate-URL: https://translation.odoo-community.org/projects/odoo-pim-16-0/odoo-pim-16-0-attribute_set/es/
af862b1 to
4b109b0
Compare
- Fix attribute_set native field updates during module upgrades - Fix Attribute record duplication to ensure unique names - Fix Attribute error where bool has no startswith method - Fix attribute set placeholder handling to improve compatibility - Fix popup attributes view to show more than 2 characters - Fix view styling and other compatibility improvements
4b109b0 to
474ea47
Compare
|
Done, it is now based ontop of the offical 18.0 migration ✨ |
|
/ocabot migration attribute_set |
|
Sorry @bosd you are not allowed to mark the addon to be migrated. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
Dranyel-Bosd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
|
@bosd Could you redo commit history? New language commit was added in v18. |
WIP, Should be functional. Commits are a bit of a mess. some fixes should have been backported in the v18.
But various fixes already applied here.
Based upon #225