[18.0][FIX] product_secondary_unit: UoM conversion in secondary unit mixin #2182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @sergio-teruel, |
Contributor
|
This PR has the |
AungKoKoLin1997
force-pushed
the
6285-imp-product_attribute
branch
from
9a080ba to
4cf667a
Compare
Contributor
Author
|
In my last commit, I add the configuration for qweb reports presentation. |
AungKoKoLin1997
force-pushed
the
6285-imp-product_attribute
branch
from
4cf667a to
3722287
Compare
This was referenced Jan 20, 2026
Open
yostashiro
reviewed
Jan 20, 2026
AungKoKoLin1997
force-pushed
the
6285-imp-product_attribute
branch
from
3722287 to
f207287
Compare
yostashiro
reviewed
Jan 21, 2026
AungKoKoLin1997
force-pushed
the
6285-imp-product_attribute
branch
2 times, most recently
from
5fb5d21 to
6eb4143
Compare
AungKoKoLin1997
changed the title
AungKoKoLin1997
force-pushed
the
6285-imp-product_attribute
branch
2 times, most recently
from
3b7c135 to
c8dcb39
Compare
yostashiro
reviewed
Jan 22, 2026
AungKoKoLin1997
force-pushed
the
6285-imp-product_attribute
branch
2 times, most recently
from
0ce7836 to
687642c
Compare
nobuQuartile
approved these changes
Jan 23, 2026
Contributor
nobuQuartile
left a comment
nobuQuartile
left a comment
There was a problem hiding this comment.
Functional review and code review: LGTM
kanda999
approved these changes
Jan 23, 2026
kanda999
left a comment
kanda999
left a comment
There was a problem hiding this comment.
LGTM: it works as expected in my local env
yostashiro
reviewed
Jan 23, 2026
Replace _get_factor_line() with uom._compute_quantity() to fix incorrect conversion when line UoM differs from product's base UoM. The previous method failed for certain UoM combinations (e.g., line in L, product in mL). Co-authored-by: Yoshi Tashiro <tashiro@quartile.co>
AungKoKoLin1997
force-pushed
the
6285-imp-product_attribute
branch
from
687642c to
b1cdab7
Compare
yostashiro
reviewed
Jan 23, 2026
Co-authored-by: Yoshi Tashiro <tashiro@quartile.co>
AungKoKoLin1997
force-pushed
the
6285-imp-product_attribute
branch
from
b1cdab7 to
343ef59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: OCA/stock-logistics-warehouse#2496
@qrtl QT6285