[19.0][MIG] product_configurator_mrp: Migration to 19.0.#177
Open
[19.0][MIG] product_configurator_mrp: Migration to 19.0.#177
Conversation
…as not saveing after reset
B pass the raise ValidationError if user is in sudo mode
pyUtils.eval('context', event.data.attrs.context) -> the context key is not in "event.data.attrs.context" -> Oddo client error when user clic on smart button (for instance, the button "Forecasted" on the product form or the "Partner Ledger" on the contact form)
[IMP] Add Bom Line if no config_id [FIX] Removed unused UserError [IMP] Better config set attribute matching [FIX] Travis [IMP] Don't create bom if no bom lines [FIX] no bom line if
…t should copy over the operations from the master BOM
Co-authored-by: Daniel Reis <dreis@opensourceintegrators.com>
Correction of bug access key "product_qty" not in dictionary
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-configurator-16.0/product-configurator-16.0-product_configurator_mrp Translate-URL: https://translation.odoo-community.org/projects/product-configurator-16-0/product-configurator-16-0-product_configurator_mrp/
Currently translated at 100.0% (47 of 47 strings) Translation: product-configurator-16.0/product-configurator-16.0-product_configurator_mrp Translate-URL: https://translation.odoo-community.org/projects/product-configurator-16-0/product-configurator-16-0-product_configurator_mrp/it/
The read method should be able to take an empty fields definition, indicating we should read all fields. The implementation assumed (and required) that the read metho always be given a list of fields, and would explode if called with None.
The implementation does not properly handle being called for multiple records at once. Doing so will fill certain dynamic values in the first record's result, but will leave the other results un-filled. Rather than allow such a difficult-to-debug error to occur, instead error out early with a clear error message.
Context is a frozenset, so if we want to get a new context without one of its values, we have to re-construct it without the unwanted key.
* safe_eval API changed * Tests were not imported and quite old, so rewrote them
aisopuro
changed the title
|
Code review done and it looks good to me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #168
There seem to be... a lot of commits. The changes I've made are in this range: edbbf99...13adea3 (
[IMP] product_configurator_mrp: pre-commit manual fixesto[MIG] product_configurator_mrp: Migration to 19.0).There were some bugfixes and improvements along the way: I've kept things in separate commits so they would be easier to review and cherry-pick to other branches as necessary.