Skip to content

[19.0][MIG] product_pack: migration to 19.0#223

Merged
OCA-git-bot merged 106 commits intoOCA:19.0from
apikcloud:19.0-mig-product_pack
Nov 6, 2025
Merged

[19.0][MIG] product_pack: migration to 19.0#223
OCA-git-bot merged 106 commits intoOCA:19.0from
apikcloud:19.0-mig-product_pack

Conversation

@apik-mgu
Copy link

No description provided.

Juan Jose Scarafia and others added 30 commits October 16, 2025 14:58
INIT

ADD pot files and module for agrimesores
IMP product pack to support surveyor packs

IMP pack description

IMP add product pack standar functionality for v8 and general improvements

IMP discounts and portal distributors permissions

FIX product_pack license and author

FIX prod pack available

IMP pack to restrict company in products

FIX pack company restriction
IMP product_pack format

FIX fix_digits_compute_to_digits

IMP IMPORTANT imprrovements on product pack, get pack with sale order constraint

IMP use constraint on sale line and not sale order for product packs

IMP implement totalice price on product pack

IMP update pack manifest

FIX prod pack copy sale order

FIX contraint

IMP compt with other modules

FIX prod pack @api.multi
9.0 FIX filter the taxes by company (OCA#111)
* [REL] replace __openerp__ for __manifest__

* [REL] replace openerp imports for odoo

* [REL] some python3 exceptions

* [REL] replace openerp by odoo on xml files

* [REL] delete utf-8 line on python files

* [REL] some minor fixes for migration to v11

* [FIX] runbot link
* [FIX] xml files names

* [REL] migration product_pack to 11.0
* [FIX] Update README
* [FIX] remove openerp tags and data tags
* [IMP] change some funtion to improve funcionality
* [FIX] change name to xml and .py files according guidelines
* [FIX] remove api.one decorators

* [FIX] update readme

* [FIX] Remove "encoding: utf-8"

* [FIX] remove api.multi, string not necesary and some other fixes

* [FIX] demo data to separate according Guidelines

* [FIX] fix names in fields

* [FIX] remove executable
* [ADD] product_pack: Add compatibility with website_sale.

* [ADD] product_pack: Allow product pack modify

* [ADD] product_pack: In sale order do not let to delete/modify a line that
belongs to a pack

* [ADD] product_pack: Be able to edit pack lines inf allow_modify_pack is set in
product.

* [ADD] product_pack: Do not compute price in cart for components_price packs

[FIX] product_pack: Pack line price fixed (take into account pricelist) (OCA#187)

* [FIX] product_pack: Pack line price fixed (take into account pricelist)

Proper compute pack line price using price instead of list_price

* [FIX] product_pack: Allow Modidy Pack only showed for Components price packs

* [FIX] product_pack: When changing pack_price_type clean allow_modify_pack if
needed.
…mplate view (OCA#189)

[FIX] we add prefetch_fields becase if not the stock it's no correct when this method it's call from website (OCA#191)
…scount. (OCA#197)

Formerly was only taking into account the product packs discount, now take
into account both discounts.

Also we simplify the way that get_sale_order_line_vals works and now is
simplier and use Odoo's onchange methods to compute the lines values.

[FIX] product_pack: Pack component now have the tax of the company (OCA#198)

Before this fix the product's packs new sale order line have multiple taxes:
one por each company. Actually only need to add the taxes realated to the
sale order's company.

[FIX] product_pack: compute proper components prices (OCA#199)

In some cases the values were prefetched and it was throwing bad prices.
we add prefetch_fields to the context of the packs and that solve it.

[FIX/IMP] product_pack: Allow modify pack and do not reset after confirm website sale order (OCA#201)

* [FIX] product_pack: Do not reset packs components when confirm sale order.

If a sale order is updated from the website whrn confirm the order we do
not expand the pack, we usit as it is.

* [ADD] product_pack: Allow modify pack from backend/website

Now we can choose if the product can be modified in the only int he backend or
if can be modified also in the frontend by the customers.

* [FIX] lint
Currently translated at 95.6% (43 of 45 strings)

Translation: product-pack-12.0/product-pack-12.0-product_pack
Translate-URL: https://translation.odoo-community.org/projects/product-pack-12-0/product-pack-12-0-product_pack/pt/
@apik-mgu
Copy link
Author

Fixed version error

@nicolascol
Copy link

Hi @pedrobaeza ! LGTM functional review.
I agree with rvalyi's comment about the contributors.

Copy link
Contributor

@lef-adhoc lef-adhoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The product.product_category_4 reference no longer exists in Odoo v19.

Change needed: Replace product.product_category_4 with product.product_category_services in the demo data file.

<odoo noupdate="1">
<record id="product_pack_cpu_detailed_components" model="product.product">
<field name="name">Pack CPU (Detailed - Displayed Components Price)</field>
<field name="categ_id" ref="product.product_category_4" />
Copy link
Contributor

@lef-adhoc lef-adhoc Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<field name="categ_id" ref="product.product_category_services" />

</record>
<record id="product_pack_cpu_detailed_totalized" model="product.product">
<field name="name">Pack CPU (Detailed - Totalized Components Price)</field>
<field name="categ_id" ref="product.product_category_4" />
Copy link
Contributor

@lef-adhoc lef-adhoc Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<field name="categ_id" ref="product.product_category_services" />

</record>
<record id="product_pack_cpu_detailed_ignored" model="product.product">
<field name="name">Pack CPU (Detailed - Ignored Components Price)</field>
<field name="categ_id" ref="product.product_category_4" />
Copy link
Contributor

@lef-adhoc lef-adhoc Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<field name="categ_id" ref="product.product_category_services" />

</record>
<record id="product_pack_cpu_non_detailed" model="product.product">
<field name="name">Pack CPU (Non Detailed - Totalized Components Price)</field>
<field name="categ_id" ref="product.product_category_4" />
Copy link
Contributor

@lef-adhoc lef-adhoc Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<field name="categ_id" ref="product.product_category_services" />

</record>
<record id="product_pack_pc_detailed_components" model="product.product">
<field name="name">Pack PC (Detailed - Displayed Components Price)</field>
<field name="categ_id" ref="product.product_category_4" />
Copy link
Contributor

@lef-adhoc lef-adhoc Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<field name="categ_id" ref="product.product_category_services" />

</record>
<record id="product_pack_pc_detailed_totalized" model="product.product">
<field name="name">Pack PC (Detailed - Totalized Components Price)</field>
<field name="categ_id" ref="product.product_category_4" />
Copy link
Contributor

@lef-adhoc lef-adhoc Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<field name="categ_id" ref="product.product_category_services" />

</record>
<record id="product_pack_pc_detailed_ignored" model="product.product">
<field name="name">Pack PC (Detailed - Ignored Components Price)</field>
<field name="categ_id" ref="product.product_category_4" />
Copy link
Contributor

@lef-adhoc lef-adhoc Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<field name="categ_id" ref="product.product_category_services" />

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lef-adhoc Modification effectuée dans le fichier demo/product_product_demo.xml

@apik-mgu apik-mgu force-pushed the 19.0-mig-product_pack branch from 2253fc0 to 3df29fe Compare November 5, 2025 15:45
Copy link
Contributor

@lef-adhoc lef-adhoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@pedrobaeza what would be needed to merge?

@pedrobaeza pedrobaeza changed the title [19.0] {MIG] product_pack: migrate to 19.0 [19.0][MIG] product_pack: migrate to 19.0 Nov 5, 2025
@pedrobaeza
Copy link
Member

/ocabot migration product_pack

Please change migration commit message to the one stated in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-19.0

@OCA-git-bot OCA-git-bot added this to the 19.0 milestone Nov 5, 2025
@apik-mgu apik-mgu force-pushed the 19.0-mig-product_pack branch from 3df29fe to 0573476 Compare November 6, 2025 07:48
@apik-mgu apik-mgu changed the title [19.0][MIG] product_pack: migrate to 19.0 [19.0][MIG] product_pack: migration to 19.0 Nov 6, 2025
@apik-mgu
Copy link
Author

apik-mgu commented Nov 6, 2025

@pedrobaeza We are changed the commit message

@pedrobaeza
Copy link
Member

It's still incorrect. Currently its [19.0][MIG] product_pack: Migration to 19.0, and it should be [MIG] product_pack: Migration to 19.0 (remove initial [19.0]). This is only put on the PR title to recognize which target branch, but not on the commit message.

@apik-mgu apik-mgu force-pushed the 19.0-mig-product_pack branch from 0573476 to 9d39efe Compare November 6, 2025 07:57
@apik-mgu
Copy link
Author

apik-mgu commented Nov 6, 2025

@pedrobaeza Sorry, we are done

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 19.0-ocabot-merge-pr-223-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit f1957f9 into OCA:19.0 Nov 6, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 344a16a. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.