Skip to content

Conversation

@amh-mw
Copy link
Member

@amh-mw amh-mw commented Oct 14, 2024

This adds a new subcapacity option to channels that allows the
configuration of the default capacity for autocreated child channels.

For example, environment ODOO_QUEUE_JOB_CHANNELS=root:8:subcapacity=1
would set the capacity of an autocreated root.sub channel to 1.

@OCA-git-bot
Copy link
Contributor

Hi @guewen,
some modules you are maintaining are being modified, check this out!

@amh-mw
Copy link
Member Author

amh-mw commented Oct 14, 2024

My own use case is that I run multi-company odoo with an environment like ODOO_QUEUE_JOB_CHANNELS=root:8,single:1. The single channel is for problem children that tend to generate an excess of SerializationFailure if executed in parallel. I've recently determined that those SerializationFailure are company-specific, so a channel per company would improve parallelism.

Per @sbidoul in OCA Discord

Undeclared channels are auto created at runtime, but with an unlimited capacity.

This setting allows me to limit the capacity of auto-created channels.

@amh-mw amh-mw changed the title [IMP] Make default subchannel capacity configurable. [15.0][IMP] Make default subchannel capacity configurable. Oct 14, 2024
@amh-mw amh-mw force-pushed the 15.0-default_subchannel_capacity branch 3 times, most recently from 50e748b to ee6389b Compare October 14, 2024 19:26
@amh-mw amh-mw marked this pull request as ready for review October 14, 2024 19:36
@sbidoul
Copy link
Member

sbidoul commented Oct 18, 2024

Thanks for addressing this @amh-mw

I would have a preference for configuring this in the parent channel, instead of globally.
Like this is done, for instance for the throttle config.

@amh-mw
Copy link
Member Author

amh-mw commented Oct 22, 2024

I would have a preference for configuring this in the parent channel, instead of globally. Like this is done, for instance for the throttle config.

Understood. I will unfortunately not have time to circle back around to that request until next year. Would it be possible to mark this issuenostale?

@sbidoul
Copy link
Member

sbidoul commented Oct 22, 2024

@amh-mw Count on me to repoen it if the stale bot closes it. Can you set it Draft? [done]

@sbidoul sbidoul marked this pull request as draft October 22, 2024 15:47
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 23, 2025
@sbidoul sbidoul removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 23, 2025
@amh-mw amh-mw changed the title [15.0][IMP] Make default subchannel capacity configurable. [15.0][IMP] queue_job: Configure default subchannel capacity. Feb 26, 2025
@amh-mw amh-mw force-pushed the 15.0-default_subchannel_capacity branch 2 times, most recently from 1783ea6 to b60f638 Compare February 26, 2025 14:58
@amh-mw amh-mw marked this pull request as ready for review February 26, 2025 16:52
This adds a new `subcapacity` option to channels that allows the
configuration of the default capacity for autocreated child channels.

For example, environment `ODOO_QUEUE_JOB_CHANNELS=root:8:subcapacity=1`
would set the capacity of an autocreated `root.sub` channel to 1.
@amh-mw amh-mw force-pushed the 15.0-default_subchannel_capacity branch from b60f638 to 5f898da Compare February 26, 2025 16:58
@amh-mw
Copy link
Member Author

amh-mw commented Mar 6, 2025

@sbidoul Version two ready for review.

@amh-mw
Copy link
Member Author

amh-mw commented May 7, 2025

Reopening against 18.0 #767

@amh-mw amh-mw closed this May 7, 2025
@amh-mw amh-mw deleted the 15.0-default_subchannel_capacity branch May 7, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants