Skip to content

Conversation

@tishmen
Copy link

@tishmen tishmen commented Oct 1, 2025

Scope:

  • base_import_async only

Depends on:

Summary:

  • Migrate to Odoo 19.

Temporary references:

  • test-requirements.txt adds a temporary dependency to the base PR for CI/runboat. (This will be removed once the base PR merges.)

Pre-commit:

  • Ran locally before opening; auto-fixes committed.

Tests:

  • Local install may be skipped where core base_import is absent; CI on OCA infra will validate.

@tishmen tishmen changed the title [19.0] base_import_async: migrate (new PR) [19.0] [MIG] base_import_async: migrate (new PR) Oct 1, 2025
@tishmen tishmen changed the title [19.0] [MIG] base_import_async: migrate (new PR) [19.0] [MIG] base_import_async: migrate Oct 1, 2025
@OCA OCA deleted a comment from OCA-git-bot Oct 1, 2025
@sbidoul
Copy link
Member

sbidoul commented Oct 1, 2025

/ocabot migration base_import_async

@OCA-git-bot OCA-git-bot added this to the 19.0 milestone Oct 1, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 1, 2025
8 tasks
Copy link
Contributor

@hoangtrann hoangtrann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, though you can now remove queue_job from test-requirements.txt

@tishmen tishmen force-pushed the pr2/base_import_async branch from f42ea1a to e83c07f Compare January 9, 2026 10:36
- Move BaseImportImport wizard code to wizard/\n- Update tests and async import flow\n- Update pre-commit exclusions
@tishmen tishmen force-pushed the pr2/base_import_async branch from 4416fe3 to eba1ed2 Compare January 9, 2026 15:47
@tishmen
Copy link
Author

tishmen commented Jan 9, 2026

Hi @hoangtrann @sbidoul , I rebased the branch on 19.0, resolved the conflicts, and addressed the review nits (removed the obsolete test-requirements.txt dependency and the “Odoo 19” comment). I also restored requirements.txt (generated from external_dependencies) and added tests to improve coverage. Finally, I squashed the PR into a single commit; CI is running again on the new head. Please double check if this is ready to get merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants