Skip to content

[WIP] queue_job: improve memory usage #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AnizR wants to merge 1 commit into from
Closed

[WIP] queue_job: improve memory usage #848

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions queue_job/job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
import os
import sys
import uuid
import weakref
from datetime import datetime, timedelta
from functools import total_ordering
from random import randint
Expand Down Expand Up @@ -438,6 +437,12 @@ def db_records_from_uuids(env, job_uuids):
record = model.search([("uuid", "in", tuple(job_uuids))])
return record.with_env(env).sudo()

@staticmethod
def db_check_uuids_in_db(env, job_uuids):
model = env["queue.job"].sudo()
record_uuids = model.search_read([("uuid", "in", tuple(job_uuids))], ["uuid"])
return record_uuids

def __init__(
self,
func,
Expand Down Expand Up @@ -518,7 +523,6 @@ def __init__(
self.__depends_on_uuids = set()
self.__reverse_depends_on_uuids = set()
self._depends_on = set()
self._reverse_depends_on = weakref.WeakSet()

self.priority = priority
if self.priority is None:
Expand Down Expand Up @@ -560,10 +564,8 @@ def add_depends(self, jobs):
if self in jobs:
raise ValueError("job cannot depend on itself")
self.__depends_on_uuids |= {j.uuid for j in jobs}
self._depends_on.update(jobs)
for parent in jobs:
parent.__reverse_depends_on_uuids.add(self.uuid)
parent._reverse_depends_on.add(self)
if any(j.state != DONE for j in jobs):
self.state = WAIT_DEPENDENCIES

Expand Down Expand Up @@ -689,9 +691,15 @@ def _store_values(self, create=False):
vals["identity_key"] = self.identity_key

dependencies = {
"depends_on": [parent.uuid for parent in self.depends_on],
"depends_on": [
rec["uuid"]
for rec in Job.db_check_uuids_in_db(self.env, self.__depends_on_uuids)
],
"reverse_depends_on": [
children.uuid for children in self.reverse_depends_on
rec["uuid"]
for rec in Job.db_check_uuids_in_db(
self.env, self.__reverse_depends_on_uuids
)
],
}
vals["dependencies"] = dependencies
Expand Down Expand Up @@ -796,14 +804,6 @@ def depends_on(self):
self._depends_on = Job.load_many(self.env, self.__depends_on_uuids)
return self._depends_on

@property
def reverse_depends_on(self):
if not self._reverse_depends_on:
self._reverse_depends_on = Job.load_many(
self.env, self.__reverse_depends_on_uuids
)
return set(self._reverse_depends_on)

@property
def description(self):
if self._description:
Expand Down
Loading