[17.0][FIX] sale_invoice_policy: invoice policy#4145
Open
Drsmartinkus wants to merge 2 commits intoOCA:17.0from
Open
[17.0][FIX] sale_invoice_policy: invoice policy#4145Drsmartinkus wants to merge 2 commits intoOCA:17.0from
Drsmartinkus wants to merge 2 commits intoOCA:17.0from
Conversation
Fix sale order invoice policy to work regardless of required setting. Before this fix, the sale order invoice_policy field only affected invoicing calculations when invoice_policy_required was set to True. When invoice_policy_required was False, the invoice policy was ignored, and the system fell back to the default product level invoice policies. This was problematic because users could set an invoice policy on sale orders, but it would not work. Now the sale order invoice policy works correctly even when the field is not marked as required, allowing optional but functional invoice policies.
sebalix
approved these changes
Feb 6, 2026
sebalix
changed the title
Drsmartinkus
force-pushed
the
17.0-fix-sale_invoice_policy-invoice-policy-required
branch
from
16ded28 to
c763bb8
Compare
Allow empty value on invoice_policy by removing readonly option. Without this it's not possible to select nothing which forces always to use invoice policy from sale order level.
Drsmartinkus
force-pushed
the
17.0-fix-sale_invoice_policy-invoice-policy-required
branch
from
c763bb8 to
cfe6ebe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix sale order invoice policy to work regardless of required setting.
Before this fix, the sale order invoice_policy field only affected invoicing calculations when invoice_policy_required was set to True. When invoice_policy_required was False, the invoice policy was ignored, and the system fell back to the default product level invoice policies.
This was problematic because users could set an invoice policy on sale orders, but it would not work. Now the sale order invoice policy works correctly even when the field is not marked as required, allowing optional but functional invoice policies.