Skip to content

[16.0][FIX] sale_loyalty_exclude: Apply a domain to product_ids so tht only non-excluded products are displayed.#4157

Open
SuShanVoong wants to merge 1 commit intoOCA:16.0from
factorlibre:16.0-fix-sale_loyalty_exclude
Open

[16.0][FIX] sale_loyalty_exclude: Apply a domain to product_ids so tht only non-excluded products are displayed.#4157
SuShanVoong wants to merge 1 commit intoOCA:16.0from
factorlibre:16.0-fix-sale_loyalty_exclude

Conversation

@SuShanVoong
Copy link

Description

It was identified that within discount programs, when selecting products in the reward rules configuration, it was possible to choose products that were marked as excluded from loyalty programs.

This behavior allowed excluded products to be configured in discount rules, leading to inconsistent discount logic.

Cases Covered with This Improvement

  • Prevents excluded products from being selectable within discount rule configurations.
  • Ensures that only eligible (non-excluded) products can be added to loyalty reward rules.

Implemented Solution

A domain filter has been added in the sale_loyalty_exclude module to ensure that only products not marked as excluded are displayed when configuring discount program rules.

This guarantees consistency between product configuration and loyalty rule eligibility.

FL-571-7802

…at only non-excluded products are displayed.
@SuShanVoong
Copy link
Author

Evidence of Correct Functionality:

2026-02-16_13-55
Grabacion.de.pantalla.desde.2026-02-16.15-53-38.webm

@SuShanVoong SuShanVoong reopened this Feb 16, 2026
Copy link

@LuisAlejandroS LuisAlejandroS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants