[18.0][MIG] sale_order_restrict _copy_archived_product: Migration to 18.0#4158
[18.0][MIG] sale_order_restrict _copy_archived_product: Migration to 18.0#4158
Conversation
Jaimermaccione
left a comment
Jaimermaccione
left a comment
There was a problem hiding this comment.
@Anxo82 Module reviewed on Runboat.
Tests Performed
1. Quotation with Archived Product
- Attempted to duplicate a quotation containing an archived product.
- Result: Duplication is correctly blocked.
- A validation message clearly indicates the archived product.
2. Confirmed Sales Order with Archived Product
- Attempted to duplicate a confirmed sales order containing an archived product.
- Result: Duplication is correctly blocked.
3. Archived Product Variants
- If the sales order contains the archived variant → duplication is blocked.
- If the sales order contains a different active variant of the same product template → duplication is allowed.
4. Sections and Notes
- Sections and note lines do not affect the validation.
- They do not trigger any blocking behavior.
5. Reactivated Product
- If the archived product is reactivated, duplication is allowed again as expected.
6. Different Product Types
- Tested with stockable products and services.
- Result: Duplication is correctly blocked in both cases when the product is archived.
Conclusion
The module behaves consistently according to its intended functional scope.
LGTM!
|
@HaraldPanten Could you please review it and, if you agree, merge it? |
HaraldPanten
left a comment
HaraldPanten
left a comment
There was a problem hiding this comment.
/ocabot migration sale_order_restrict _copy_archived_product
/ocabot merge nobump
|
Hi @HaraldPanten. Your command failed:
Ocabot commands
More information
|
|
/ocabot migration sale_order_restrict_copy_archived_product |
|
What a great day to merge this nice PR. Let's do it! |
|
@HaraldPanten your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-4158-by-HaraldPanten-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
Currently translated at 100.0% (2 of 2 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_order_restrict_copy_archived_product Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_order_restrict_copy_archived_product/es/
Anxo82
force-pushed
the
18.0-mig-sale_order_restrict_copy_archived_product
branch
from
c4af6ef to
d92a80e
Compare
With the changes introduced in odoo/odoo@de056cc#diff-b37c7fd5520c97a29ddc59495779e7be61a66e15e85603928e27b3affb9dc31f, an error was occurring because the change validation on the model was being performed before tearDownClass was executed. Therefore, it has been modified so that the mock changes are applied in each test and cleaned up after each test. This way, the error will no longer appear and the test will run normally.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-18.0/sale-workflow-18.0-sale_elaboration Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-18-0/sale-workflow-18-0-sale_elaboration/
Currently translated at 4.2% (2 of 47 strings) Translation: sale-workflow-18.0/sale-workflow-18.0-sale_manual_delivery Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-18-0/sale-workflow-18-0-sale_manual_delivery/fr/
Currently translated at 94.4% (17 of 18 strings) Translation: sale-workflow-18.0/sale-workflow-18.0-sale_order_line_menu Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-18-0/sale-workflow-18-0-sale_order_line_menu/ja/
|
@HaraldPanten The branch has been rebased on the latest target branch. Could you please try merging again? |
|
This PR has the |
@Anxo82 I think we still have conflicts |
11 participants
@HaraldPanten