-
-
Notifications
You must be signed in to change notification settings - Fork 326
[18.0][MIG] base_external_dbsource_mysql: Migration to version 18.0 #389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] base_external_dbsource_mysql: Migration to version 18.0 #389
Conversation
* Heavily refactor code for reusability * Split all sources into independent modules * Add more test coverage * Add CRUD methods * Add iterator execute return to roadmap [UPD] Update base_external_dbsource_mysql.pot
The amount of shared code is so insignificant, that it doesn't worth to depend on base_external_dbsource_sqlite. [UPD] Update base_external_dbsource_mysql.pot [ADD] icon.png
[UPD] Update base_external_dbsource_mysql.pot [UPD] README.rst
|
@christian-ramos-tecnativa Already migrated open PR: #388 |
|
@Nikul-OSI I think that's not the same module |
|
/ocabot migration base_external_dbsource_mysql |
base_external_dbsource_mysql/tests/test_base_external_dbsource.py
Outdated
Show resolved
Hide resolved
eab0393 to
305c135
Compare
pedrobaeza
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge nobump
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at f01571f. Thanks a lot for contributing to OCA. ❤️ |
Standard migration, based in:
@Tecnativa TT57474