Skip to content

[16.0][FIX]hr_timesheet_sheet_autodraft: fix department in timesheet sheet#786

Merged
OCA-git-bot merged 1 commit intoOCA:16.0from
PyTech-SRL:16.0-timesheet-sheet-department
Feb 19, 2026
Merged

[16.0][FIX]hr_timesheet_sheet_autodraft: fix department in timesheet sheet#786
OCA-git-bot merged 1 commit intoOCA:16.0from
PyTech-SRL:16.0-timesheet-sheet-department

Conversation

@quirino95
Copy link

When an employee requests some time-off, timesheet sheet is created if it doesn't exist, but sometimes department could be set wrong. By default, it's set with the same department of who approves time-off.

This is not correct, so my fix set department as the same of the employee who requested time-off.

These are the steps to reproduce the bug:

  1. Module hr_timesheet_sheet_autodraft should be active and Auto-draft Timesheet setting should be checked;
  2. Assign department A to employee 1
  3. Assign department B to employee 2
  4. Make sure project and task are correctly set in the time-off type that will be used for the test;
  5. Employee 1 requests time-off;
  6. Employee 2 approves time-off;

On approval, a new timesheet will be created for employee 1 with the department of employee 2.
With this fix, timesheet will be created with department of employee 1.

@github-actions
Copy link

github-actions bot commented Oct 5, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 5, 2025
@HekkiMelody
Copy link

@OCA/human-resources-maintainers Hi, this is a simple PR, could we ask for a review? We can FW once it's merged. Thanks!

@dreispt dreispt removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 6, 2025
@github-actions
Copy link

github-actions bot commented Feb 8, 2026

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 8, 2026
@Saran440
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-786-by-Saran440-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 17, 2026
Signed-off-by Saran440
@OCA-git-bot
Copy link
Contributor

@Saran440 your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-786-by-Saran440-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@Saran440
Copy link
Member

@quirino95 Could you update code again, please?

@quirino95
Copy link
Author

Hi @Saran440,

Issue should be related to OCA/oca-addons-repo-template#333.

@Saran440 Saran440 removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 18, 2026
@quirino95
Copy link
Author

Hi @Saran440,

I've created #880 to integrate updates from OCA/oca-addons-repo-template#333.
I'd like for you to take a look at it, thank you!

@Saran440
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-786-by-Saran440-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8ce1d91 into OCA:16.0 Feb 19, 2026
12 of 13 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6f8e79c. Thanks a lot for contributing to OCA. ❤️

@quirino95 quirino95 deleted the 16.0-timesheet-sheet-department branch February 19, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants