[16.0][FIX]hr_timesheet_sheet_autodraft: fix department in timesheet sheet#786
Conversation
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
|
@OCA/human-resources-maintainers Hi, this is a simple PR, could we ask for a review? We can FW once it's merged. Thanks! |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
@Saran440 your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-786-by-Saran440-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
@quirino95 Could you update code again, please? |
|
Hi @Saran440, Issue should be related to OCA/oca-addons-repo-template#333. |
|
Hi @Saran440, I've created #880 to integrate updates from OCA/oca-addons-repo-template#333. |
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 6f8e79c. Thanks a lot for contributing to OCA. ❤️ |
When an employee requests some time-off, timesheet sheet is created if it doesn't exist, but sometimes department could be set wrong. By default, it's set with the same department of who approves time-off.
This is not correct, so my fix set department as the same of the employee who requested time-off.
These are the steps to reproduce the bug:
hr_timesheet_sheet_autodraftshould be active and Auto-draft Timesheet setting should be checked;On approval, a new timesheet will be created for employee 1 with the department of employee 2.
With this fix, timesheet will be created with department of employee 1.